PR responses

src/benchmarks/micro/MicroBenchmarks.csproj

@@ -3,6 +3,7 @@
   <PropertyGroup>
     <!-- Used by Python script to narrow down the specified target frameworks to test, and avoid downloading all supported SDKs -->
     <!-- Supported target frameworks -->
+    <TargetFrameworks>$(PERFLAB_TARGET_FRAMEWORKS)</TargetFrameworks>
     <TargetFrameworks Condition="'$(TargetFrameworks)' == '' AND '$(OS)' == 'Windows_NT'">net461;netcoreapp3.1;net5.0;net6.0;net7.0</TargetFrameworks>
     <TargetFrameworks Condition="'$(TargetFrameworks)' == ''">netcoreapp3.1;net5.0;net6.0;net7.0</TargetFrameworks>
     <NoWarn>$(NoWarn);CS8002</NoWarn>

src/benchmarks/micro/Program.cs

@@ -24,8 +24,6 @@ static int Main(string[] args)
             Dictionary<string, object> parameterFilterValue;
             bool getDiffableDisasm;
 
-            //Console.ReadLine();
-
             // Parse and remove any additional parameters that we need that aren't part of BDN
             try {
                 argsList = CommandLineOptions.ParseAndRemoveIntParameter(argsList, "--partition-count", out partitionCount);
@@ -55,8 +53,7 @@ static int Main(string[] args)
                         categoryExclusionFilterValue: categoryExclusionFilterValue,
                         parameterFilterValue: parameterFilterValue,
                         getDiffableDisasm: getDiffableDisasm)
-                    .AddValidator(new NoWasmValidator(Categories.NoWASM))
-                    .WithOptions(ConfigOptions.DisableOptimizationsValidator))
+                    .AddValidator(new NoWasmValidator(Categories.NoWASM)))
                 .ToExitCode();
         }
     }

src/harness/BenchmarkDotNet.Extensions/ParameterFilter.cs

@@ -16,18 +16,15 @@ public ParameterFilter(Dictionary<string, object> parameterValues)
     public bool Predicate(BenchmarkCase benchmarkCase)
     {
         Dictionary<string, object> items = benchmarkCase.Parameters.Items.ToDictionary<ParameterInstance, string, object>(instance => instance.Name, instance => instance.Value);
-        bool check = benchmarkCase.DisplayInfo.Contains("Perf");
-        bool check2 = benchmarkCase.DisplayInfo.Contains("Basic"); // Nothing contains "Basic"
-        bool check3 = benchmarkCase.DisplayInfo.Contains("Utf"); // Only covers Utf Encoding benchmarks
-        //*
+
         foreach (string key in _parameterValues.Keys)
         {
             if (!items.Keys.Contains(key))
                 return false;
             if (!items[key].Equals(_parameterValues[key]))
                 return false;
         }
-        //*/
+
         return true;
     }
 }

src/tests/harness/BenchmarkDotNet.Extensions.Tests/PartitionFilterTests.cs

@@ -85,7 +85,7 @@ public void NoBenchmarksAreOmitted_RealData()
                 for (int partitionIndex = 0; partitionIndex < PartitionCount; partitionIndex++)
                 {
                     PartitionFilter filter = new(PartitionCount, partitionIndex);
-                    IEnumerable<BenchmarkCase> tmp = GetAllBenchmarks(parsedConfig, runnable).SelectMany(benchmark => benchmark.BenchmarksCases);
+
                     foreach (BenchmarkCase benchmark in GetAllBenchmarks(parsedConfig, runnable).SelectMany(benchmark => benchmark.BenchmarksCases))
                     {
                         if (filter.Predicate(benchmark))