Skip to content

Allow for the passing of the runtime commit time to use in ci_setup. #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LoopedBard3 merged 5 commits into from
Oct 3, 2022
Merged

Allow for the passing of the runtime commit time to use in ci_setup. #2622

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f98340a
Add parser for the datetime to allow us to pass commit times manually…
LoopedBard3 Sep 22, 2022
f0ee761
Made the source_timestamp deliniation between being included and not …
LoopedBard3 Sep 28, 2022
12aca50
Fixed using incorrect value for commit_time.
LoopedBard3 Sep 28, 2022
90e8b2c
Added the format for the runtime commit time in ci_setup.
LoopedBard3 Sep 29, 2022
6932d0d
Setup github api to be used to get the commit_time when the passed in…
LoopedBard3 Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion scripts/ci_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import os
import sys
import datetime

from subprocess import check_output

Expand Down Expand Up @@ -94,6 +95,13 @@ def add_arguments(parser: ArgumentParser) -> ArgumentParser:
type=str,
help='Product commit sha.'
)
parser.add_argument(
'--commit-time',
dest='commit_time',
required=False,
type=str,
help='Product commit time. Format: %Y-%m-%d %H:%M:%S %z'
)
parser.add_argument(
'--repository',
dest='repository',
Expand Down Expand Up @@ -309,7 +317,15 @@ def __main(args: list) -> int:
target_framework_moniker = dotnet.FrameworkAction.get_target_framework_moniker(framework)
dotnet_version = dotnet.get_dotnet_version(target_framework_moniker, args.cli) if args.dotnet_versions == [] else args.dotnet_versions[0]
commit_sha = dotnet.get_dotnet_sdk(target_framework_moniker, args.cli) if args.commit_sha is None else args.commit_sha
source_timestamp = dotnet.get_commit_date(target_framework_moniker, commit_sha, repo_url)
if(args.commit_time is not None):
try:
parsed_timestamp = datetime.datetime.strptime(args.commit_time, '%Y-%m-%d %H:%M:%S %z').astimezone(datetime.timezone.utc)
source_timestamp = parsed_timestamp.strftime('%Y-%m-%dT%H:%M:%SZ')
except ValueError:
getLogger().warning('Invalid commit_time format. Please use YYYY-MM-DD HH:MM:SS +/-HHMM. Attempting to get commit time from api.github.com.')
source_timestamp = dotnet.get_commit_date(target_framework_moniker, commit_sha, repo_url)
else:
source_timestamp = dotnet.get_commit_date(target_framework_moniker, commit_sha, repo_url)

branch = ChannelMap.get_branch(args.channel) if not args.branch else args.branch

Expand Down