Add Convert.FromHex benchmark #3032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
previously approved these changes
May 21, 2023
Member
danmoseley
left a comment
danmoseley
left a comment
There was a problem hiding this comment.
not sure whether at some future point we might want to add a range of lengths or not -- more benchmarks has their cost. this is something.
danmoseley
reviewed
May 21, 2023
src/benchmarks/micro/libraries/System.Runtime.Extensions/Perf.Convert.cs
Show resolved
Hide resolved
danmoseley
previously approved these changes
May 21, 2023
Member
|
@LoopedBard3 fyi this failed to download the CLI, so I added some robustification. (Oddly, it needs the retries when I run locally today.) |
danmoseley
approved these changes
May 22, 2023
Member
|
@LoopedBard3 looks like someone other than me needs to sign off -- can you, and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet/runtime#86556 (comment)