Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add mono_libclang_path as an optional argument/parameter.
  • Loading branch information
LoopedBard3 committed Sep 25, 2023
commit d189f04724fb7057e5dc7ca975c49a07d16d46e8
5 changes: 3 additions & 2 deletions scripts/benchmarks_local.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def generate_all_runtype_dependencies(parsed_args: Namespace, repo_path: str, co
if check_for_runtype_specified(parsed_args, [RunType.MonoAOTLLVM]): # TODO: Is all the cross stuff needed?
artifact_mono_aot_llvm = os.path.join(get_run_artifact_path(parsed_args, RunType.MonoAOTLLVM, commit), "monoaot")
if force_regenerate or not os.path.exists(artifact_mono_aot_llvm):
build_runtime_dependency(parsed_args, repo_path, "clr+mono+libs+host+packs", additional_args=['-cross', '/p:BuildMonoAOTCrossCompiler=true', '/p:MonoLibClang="/usr/local/lib/libclang.so.16"', f'/p:AotHostArchitecture={parsed_args.architecture}', f'/p:AotHostOS={parsed_args.os}'])
build_runtime_dependency(parsed_args, repo_path, "clr+mono+libs+host+packs", additional_args=['-cross', '/p:BuildMonoAOTCrossCompiler=true', f'/p:MonoLibClang={parsed_args.mono_libclang_path}' if parsed_args.mono_libclang_path else '', f'/p:AotHostArchitecture={parsed_args.architecture}', f'/p:AotHostOS={parsed_args.os}'])

# Move to the bin/aot location
src_dir_aot = os.path.join(repo_path, "artifacts", "bin", "mono", f"{parsed_args.os}.{parsed_args.architecture}.Release", "cross", f"{parsed_args.os}-{parsed_args.architecture}")
Expand Down Expand Up @@ -562,7 +562,8 @@ def __is_valid_run_type(value):
parser.add_argument('--filter', type=str, default='*', help='Specifies the benchmark filter to pass to BenchmarkDotNet')
parser.add_argument('-f', '--framework', choices=ChannelMap.get_supported_frameworks(), default='net8.0', help='The target framework to run the benchmarks against.') # Can and should this accept multiple frameworks?
parser.add_argument('--csproj', type=str, default=os.path.join("..", "src", "benchmarks", "micro", "MicroBenchmarks.csproj"), help='The path to the csproj file to run benchmarks against.')
parser.add_argument('--wasm-engine-path', type=str, help='The full path to the wasm engine to use for the benchmarks. e.g. /usr/local/bin/v8')
parser.add_argument('--wasm-engine-path', type=str, help='The full path to the wasm engine to use for the benchmarks. e.g. /usr/local/bin/v8') # TODO: Setup required arguments
parser.add_argument('--mono-libclang-path', type=str, help='The full path to the clang compiler to use for the benchmarks. e.g. "/usr/local/lib/libclang.so.16", used for "MonoLibClang" build property.') # TODO: Setup required arguments

def get_default_os():
system = platform.system().lower()
Expand Down