-
Notifications
You must be signed in to change notification settings - Fork 479
CA1416 handle call-site empty sets causing warnings when TFM attributes applied #4740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
48c37cc
Handle call site empty sets causing warnings when TFM attributes applied
buyaa-n 3116175
Keep callsite info in the cache so that subsequent calls have that info
buyaa-n 8aee460
Apply feedback
buyaa-n 6681bcd
Add Remove method for SmallDictionary, apply more feedback
buyaa-n f59f285
apply feedback
buyaa-n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
|
||
| using System; | ||
| using Analyzer.Utilities; | ||
|
|
||
| namespace Microsoft.NetCore.Analyzers.InteropServices | ||
| { | ||
|
|
@@ -22,14 +23,28 @@ public sealed partial class PlatformCompatibilityAnalyzer | |
| /// - UnsupportedFirst - keeps the lowest version of [UnsupportedOSPlatform] attribute found | ||
| /// - UnsupportedSecond - keeps the second lowest version of [UnsupportedOSPlatform] attribute found | ||
| /// </summary> | ||
| private class PlatformAttributes | ||
| private class Versions | ||
| { | ||
| public Version? SupportedFirst { get; set; } | ||
| public Version? SupportedSecond { get; set; } | ||
| public Version? UnsupportedFirst { get; set; } | ||
| public Version? UnsupportedSecond { get; set; } | ||
| public bool HasAttribute() => SupportedFirst != null || UnsupportedFirst != null || | ||
| public bool IsSet() => SupportedFirst != null || UnsupportedFirst != null || | ||
| SupportedSecond != null || UnsupportedSecond != null; | ||
| } | ||
|
|
||
| private class PlatformAttributes | ||
| { | ||
| public PlatformAttributes() { } | ||
|
|
||
| public PlatformAttributes(Callsite callsite, SmallDictionary<string, Versions> platforms) | ||
| { | ||
| Callsite = callsite; | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because of attributes kept in the cache i needed to add Call-site info for subsequent calls made within that call site |
||
| Platforms = platforms; | ||
| } | ||
|
|
||
| public SmallDictionary<string, Versions>? Platforms { get; set; } | ||
buyaa-n marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| public Callsite Callsite { get; set; } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.