Cleanup DoNotUseWhenAllOrWaitAllWithSingleArgument

[Youssef1313]

Quick follow-up to #4841

• Removed unnecessary derived classes.
• Used non-localized equivalence key.
• Renamed all contexts to `context.
• Used SymbolEqualityComparer.Default

cc: @ryzngard

[Youssef1313]

@mavasani I'm unable to debug the failure.

Locally, the tests fail with: NuGet.Packaging.Core.PackagingException : The package is missing the required nuspec file. Path: C:\Users\Youssef\AppData\Local\Temp\test-packages\Microsoft.NETCore.App.Ref.3.1.0

I have no clue how to fix this. :/ Deleting test-packages folder fixed it.

But the behavior of IOperation API looks very strange:

Is that a bug in the operation tree?

[codecov]

Codecov Report

Merging #5060 (0b5e5c1) into release/6.0.1xx-preview4 (535cbe7) will increase coverage by 0.00%.
The diff coverage is 91.66%.

@@                    Coverage Diff                    @@
##           release/6.0.1xx-preview4    #5060   +/-   ##
=========================================================
  Coverage                     95.55%   95.56%           
=========================================================
  Files                          1205     1203    -2     
  Lines                        274343   274337    -6     
  Branches                      16632    16632           
=========================================================
+ Hits                         262151   262157    +6     
  Misses                         9988     9988           
+ Partials                       2204     2192   -12     

[Youssef1313]

System.AggregateException : One or more errors occurred. (Unexpected Null)\n---- System.InvalidOperationException : Unexpected Null

TestCodeFixToEnableAnalyzerReleaseTracking failed 😕 , closing and re-opening

[ryzngard]

oops 😅 I really thought I had this change in already. Thanks for fixing!

[ryzngard]

I thought symbol.Equals(otherSymbol) implicitly used the SymbolEqualityComparer.Default if available?

[Youssef1313]

@ryzngard It does. But there is an analyzer (RS1024) to enforce using SymbolEqualityComparer explicitly to make the intent clear.

Currently the analyzer is disabled due to few bugs and will be re-enabled once they are fixed.

[ryzngard]

@mavasani I'm unable to debug the failure.

Locally, the tests fail with: NuGet.Packaging.Core.PackagingException : The package is missing the required nuspec file. Path: C:\Users\Youssef\AppData\Local\Temp\test-packages\Microsoft.NETCore.App.Ref.3.1.0

I have no clue how to fix this. :/ Deleting test-packages folder fixed it.

But the behavior of IOperation API looks very strange:

Is that a bug in the operation tree?

It looks like you figured this out, but the Value being an implicitly generated IArrayCreationOperation changes the behavior slightly.

[ryzngard]

Thanks for doing this!