Skip to content

Fix concurrency issue in CA1069 analyzer #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RikkiGibson merged 5 commits into from
Jul 16, 2021
Merged

Fix concurrency issue in CA1069 analyzer #5243

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53bd12f
Fix concurrency issue in CA1069 analyzer
RikkiGibson Jul 14, 2021
31f5935
Add test
RikkiGibson Jul 14, 2021
fe8d256
Address feedback
RikkiGibson Jul 15, 2021
37d8ae9
Add bitwise duplication test
RikkiGibson Jul 15, 2021
7264d62
Use markup for compiler errors in tests
RikkiGibson Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use markup for compiler errors in tests
  • Loading branch information
@RikkiGibson
RikkiGibson committed Jul 16, 2021
commit 7264d6240797e3bac8602f83e3b0019f052fdc82
15 changes: 6 additions & 9 deletions ...osoft.CodeQuality.Analyzers/ApiDesignGuidelines/EnumShouldNotHaveDuplicatedValuesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,20 +549,18 @@ public class C

public enum MyEnum
{
Value1 = C.I
}",
DiagnosticResult.CompilerError("CS0133").WithSpan(9, 14, 9, 17).WithArguments("MyEnum.Value1"));
Value1 = {|CS0133:C.I|}
}");

await VerifyVB.VerifyAnalyzerAsync(@"
Public Module M
Public I As Integer = 1
End Module

Public Enum MyEnum
Value1 = M.I
Value1 = {|BC30059:M.I|}
End Enum
",
DiagnosticResult.CompilerError("BC30059").WithSpan(7, 14, 7, 17));
");
}

[Fact]
Expand All @@ -571,9 +569,8 @@ public async Task EnumMemberNullConstantValue_NoDiagnostic()
await VerifyCS.VerifyAnalyzerAsync(@"
public enum MyEnum
{
Value1 = null
}",
DiagnosticResult.CompilerError("CS0037").WithSpan(4, 14, 4, 18).WithArguments("int"));
Value1 = {|CS0037:null|}
}");

await VerifyVB.VerifyAnalyzerAsync(@"
Public Enum MyEnum
Expand Down