Skip to content

CA1416 MacCatalyst is a superset of iOS #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buyaa-n merged 8 commits into from
Aug 5, 2021
Merged

CA1416 MacCatalyst is a superset of iOS #5266

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
250b091
MacCatalyst is superset of Ios
buyaa-n Jul 20, 2021
a18792c
Apply feedback
buyaa-n Jul 26, 2021
06dcc22
Merge branch 'release/6.0.1xx' of github.com:dotnet/roslyn-analyzers …
buyaa-n Jul 26, 2021
ad21395
Use 6.0 preview 6 for testing
buyaa-n Jul 26, 2021
d80815f
Put mock API source into Debug mode
buyaa-n Jul 26, 2021
83420fa
Updates for guard attributes scenario
buyaa-n Jul 30, 2021
0765fe2
Make field readonly
buyaa-n Jul 30, 2021
7824cf6
Update ios, maccatalyst parent child scenario
buyaa-n Jul 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use 6.0 preview 6 for testing
  • Loading branch information
@buyaa-n
buyaa-n committed Jul 26, 2021
commit ad21395f70fc5bd981ad4150c9c8725c4c29eb79
37 changes: 6 additions & 31 deletions ...NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.GuardedCallsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4022,7 +4022,7 @@ void SupportedOnWindowsLinuxOsx() { }

[SupportedOSPlatform(""linux"")]
void SupportedOnLinux() { }
}" + MockApisCsSource;
}";

await VerifyAnalyzerAsyncCs(source, s_msBuildPlatforms,
VerifyCS.Diagnostic(PlatformCompatibilityAnalyzer.OnlySupportedCsAllPlatforms).WithLocation(0).
Expand Down Expand Up @@ -4101,7 +4101,7 @@ void UnsupportedOnLinux() { }
[UnsupportedOSPlatform(""Linux"")]
[UnsupportedOSPlatform(""ios"")]
void UnsupportedOnLinuxWindowsIos() { }
}" + MockApisCsSource;
}";

await VerifyAnalyzerAsyncCs(source, s_msBuildPlatforms);
}
Expand Down Expand Up @@ -4165,7 +4165,7 @@ void SupportedOnWindows10LinuxMacOS14() { }

[SupportedOSPlatform(""windows8.0"")]
void SupportedOnWindows8() { }
}" + MockApisCsSource;
}";

await VerifyAnalyzerAsyncCs(source, s_msBuildPlatforms,
VerifyCS.Diagnostic(PlatformCompatibilityAnalyzer.UnsupportedCsReachable).WithLocation(0).WithArguments("Test.UnsupportedOnLinuxWindows10Ios91()",
Expand Down Expand Up @@ -4250,7 +4250,7 @@ void SupportedOnWindowsUntil10AndLinux() { }
[SupportedOSPlatform(""Windows"")]
[UnsupportedOSPlatform(""Windows10.0"")]
void SupportedOnWindowsUntil10() { }
}" + MockApisCsSource;
}";

await VerifyAnalyzerAsyncCs(source, s_msBuildPlatforms,
VerifyCS.Diagnostic(PlatformCompatibilityAnalyzer.UnsupportedCsReachable).WithLocation(0).WithArguments("Test.UnsupportedOnWindows8IosSupportsIos14_19()",
Expand Down Expand Up @@ -4323,7 +4323,7 @@ void SupportedOnWindows10Linux() { }

[SupportedOSPlatform(""windows8.0"")]
void SupportedOnWindows8() { }
}" + MockApisCsSource;
}";

await VerifyAnalyzerAsyncCs(source, s_msBuildPlatforms);
}
Expand Down Expand Up @@ -4375,7 +4375,7 @@ public static void M1() { }
public static bool IsSupported { get; }
public static void M2() { }
}
" + MockApisCsSource;
";

await VerifyAnalyzerAsyncCs(source, s_msBuildPlatforms);
}
Expand Down Expand Up @@ -4450,31 +4450,6 @@ void M1()
#endif

private readonly string MockApisCsSource = @"
namespace System.Runtime.Versioning
{
[AttributeUsage(AttributeTargets.Class |
AttributeTargets.Method |
AttributeTargets.Property |
AttributeTargets.Field |
AttributeTargets.Struct,
AllowMultiple = true, Inherited = false)]
public sealed class SupportedOSPlatformGuardAttribute : Attribute
{
public SupportedOSPlatformGuardAttribute(string platformName) { }
}

[AttributeUsage(AttributeTargets.Class |
AttributeTargets.Method |
AttributeTargets.Property |
AttributeTargets.Field |
AttributeTargets.Struct,
AllowMultiple = true, Inherited = false)]
public sealed class UnsupportedOSPlatformGuardAttribute : Attribute
{
public UnsupportedOSPlatformGuardAttribute(string platformName) { }
}
}

namespace System
{
public class MockOperatingSystem
Expand Down
4 changes: 2 additions & 2 deletions ...itTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3975,7 +3975,7 @@ private static VerifyCS.Test PopulateTestCs(string sourceCode, params Diagnostic
var test = new VerifyCS.Test
{
TestCode = sourceCode,
ReferenceAssemblies = ReferenceAssemblies.Net.Net50,
ReferenceAssemblies = AdditionalMetadataReferences.Net60,
MarkupOptions = MarkupOptions.UseFirstDescriptor,
TestState = { }
};
Expand Down Expand Up @@ -4027,7 +4027,7 @@ private static VerifyVB.Test PopulateTestVb(string sourceCode, params Diagnostic
var test = new VerifyVB.Test
{
TestCode = sourceCode,
ReferenceAssemblies = ReferenceAssemblies.Net.Net50,
ReferenceAssemblies = AdditionalMetadataReferences.Net60,
MarkupOptions = MarkupOptions.UseFirstDescriptor,
TestState = { },
};
Expand Down