CA2018: Do not throw a diagnostic for Boolean arrays #5373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/6.0.1xx #5373 +/- ##
===================================================
- Coverage 95.62% 95.62% -0.01%
===================================================
Files 1240 1240
Lines 285426 285455 +29
Branches 17132 17134 +2
===================================================
+ Hits 272929 272956 +27
- Misses 10189 10200 +11
+ Partials 2308 2299 -9 |
Youssef1313
approved these changes
Aug 13, 2021
|
Thanks for the reviews @buyaa-n and @Youssef1313 |
Merged
This was referenced Aug 30, 2021
Merged
This was referenced Sep 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5353
CA2018 currently only checks for
ByteandSBytearray types.Booleanshould also be included, since it has a size of 1 byte.This PR adds support for
bool[]arrays to prevent a false positive.cc @pgovind @Youssef1313