Skip to content

Conversation

@wzchua
Copy link

@wzchua wzchua commented Oct 29, 2021

Fixes #5682

@wzchua wzchua requested a review from a team as a code owner October 29, 2021 13:23
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #5687 (04d2f1d) into main (3541eb2) will increase coverage by 0.00%.
The diff coverage is 98.69%.

@@           Coverage Diff            @@
##             main    #5687    +/-   ##
========================================
  Coverage   95.55%   95.55%            
========================================
  Files        1280     1281     +1     
  Lines      295833   296239   +406     
  Branches    18036    18080    +44     
========================================
+ Hits       282680   283076   +396     
- Misses      10703    10711     +8     
- Partials     2450     2452     +2     

Copy link

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a NIT, overall LGTM

@buyaa-n buyaa-n requested review from jmarolf and mavasani November 12, 2021 02:05
…e/CSharpPreferHashDataOverComputeHash.Fixer.cs

Co-authored-by: Buyaa Namnan <[email protected]>
@buyaa-n buyaa-n merged commit e2d60ad into dotnet:main Nov 15, 2021
@github-actions github-actions bot added this to the vNext milestone Nov 15, 2021
@wzchua wzchua deleted the fix/ca1850/namespace-omission branch November 16, 2021 12:05
@jmarolf jmarolf modified the milestones: vNext, .NET 7.x Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CA1850 (ComputeHash) code fix removes namespace erroneously

3 participants