Skip to content

Fix 'Compare symbols correctly' false positive with custom comparers #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mavasani merged 6 commits into from
Jan 31, 2022
Merged

Fix 'Compare symbols correctly' false positive with custom comparers #5807

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1284917
Don't report compare symbols correctly for custom comparers
Youssef1313 Jan 23, 2022
66fb852
One more fix
Youssef1313 Jan 23, 2022
cdc44b2
Update src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/Compar…
Youssef1313 Jan 23, 2022
19efd30
Update CompareSymbolsCorrectlyAnalyzer.cs
Youssef1313 Jan 25, 2022
51fbca9
Apply suggestions from code review
Youssef1313 Jan 25, 2022
a70ef8e
Address review comments
Youssef1313 Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Amaury Levé <[email protected]>
  • Loading branch information
@Youssef1313 @Evangelink
Youssef1313 and Evangelink authored Jan 25, 2022
commit 51fbca9055a0300b3397775f89de149348c7e80c
4 changes: 2 additions & 2 deletions src/Microsoft.CodeAnalysis.Analyzers/UnitTests/MetaAnalyzers/CompareSymbolsCorrectlyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1249,7 +1249,7 @@ public int GetHashCode(object o1, object o2)
}

[Fact]
Copy link
Member

@Evangelink Evangelink Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the various vbnet parts?

Copy link
Member Author

@Youssef1313 Youssef1313 Jan 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix, probably in few days :(

Feel free to re-ping me if I forgot.

public async Task RS1024_CustomComparer()
public async Task RS1024_CustomComparer_Instance_Is_Interface()
{
var code = @"
using System.Collections.Generic;
Expand Down Expand Up @@ -1285,7 +1285,7 @@ private SymbolNameComparer() { }
}

[Fact]
public async Task RS1024_CustomComparer2()
public async Task RS1024_CustomComparer_Instance_Is_Type()
{
var code = @"
using System.Collections.Generic;
Expand Down