Skip to content

Implement Use 'StartsWith' instead of 'IndexOf' analyzer #6295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buyaa-n merged 28 commits into from
Dec 19, 2022
Merged

Implement Use 'StartsWith' instead of 'IndexOf' analyzer #6295

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
4d68b55
Implement Use 'StartsWith' instead of 'IndexOf' analyzer
Youssef1313 Dec 1, 2022
3f41d01
Support fix all
Youssef1313 Dec 1, 2022
cd66a08
Write a test
Youssef1313 Dec 1, 2022
64c5793
address feedback, more tests
Youssef1313 Dec 2, 2022
1af0b0e
Remove unnecessary using
Youssef1313 Dec 2, 2022
4aad448
Merge branch 'main' into starts-with
Youssef1313 Dec 6, 2022
7df3273
Simplify
Youssef1313 Dec 7, 2022
01eaaf4
Refactor
Youssef1313 Dec 7, 2022
2ce9999
wip
Youssef1313 Dec 7, 2022
c81a3e3
wip
Youssef1313 Dec 7, 2022
451ba14
Redundant comment
Youssef1313 Dec 7, 2022
4c43d0f
Remove unused using directive
Youssef1313 Dec 8, 2022
400cde7
Handle some scenarios, fix tests, and add more tests
Youssef1313 Dec 9, 2022
c9817ff
Remove TODO
Youssef1313 Dec 9, 2022
5b5026e
Fix formatting
Youssef1313 Dec 9, 2022
f23bb18
Merge branch 'main' into starts-with
Youssef1313 Dec 16, 2022
e7b76a0
Address review comments
Youssef1313 Dec 17, 2022
6605ad0
Fix build
Youssef1313 Dec 17, 2022
ebb49f1
Fix formatting
Youssef1313 Dec 17, 2022
e4dc78d
Fix build
Youssef1313 Dec 17, 2022
e42cc08
Try with elastic marker
Youssef1313 Dec 17, 2022
58ce1d6
Update generated files
Youssef1313 Dec 17, 2022
167b826
Revert "Try with elastic marker"
Youssef1313 Dec 17, 2022
437db82
Update test
Youssef1313 Dec 17, 2022
d0a198d
Run pack
Youssef1313 Dec 17, 2022
b1ad36e
Revert "Revert "Try with elastic marker""
Youssef1313 Dec 17, 2022
c358bfb
revert
Youssef1313 Dec 17, 2022
d22ec17
Apply suggestions from code review
buyaa-n Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary using
  • Loading branch information
@Youssef1313
Youssef1313 committed Dec 2, 2022
commit 1af0b0e2dc94e8cb5f3330504282ad87508a46f8
1 change: 0 additions & 1 deletion ...icrosoft.NetCore.Analyzers/Performance/UseStartsWithInsteadOfIndexOfComparisonWithZero.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the MIT license. See License.txt in the project root for license information.

using System.Collections.Immutable;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using Analyzer.Utilities;
using Analyzer.Utilities.Extensions;
Expand Down