Skip to content

Handle conversion operation as operands of IThrowOperation #6304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mavasani merged 2 commits into from
Dec 8, 2022
Merged

Handle conversion operation as operands of IThrowOperation #6304

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6629a58
Handle conversion operation as operands of IThrowOperation
mavasani Dec 8, 2022
3b84a3d
Address feedback
mavasani Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address feedback
  • Loading branch information
@mavasani
mavasani committed Dec 8, 2022
commit 3b84a3dc04789768d8acc3f596d87f9461086ca3
3 changes: 2 additions & 1 deletion src/Utilities/Compiler/Extensions/IOperationExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,8 +746,9 @@ public static IOperation WalkDownConversion(this IOperation operation, Func<ICon
var thrownObject = operation.Exception;

// Starting C# 8.0, C# compiler wraps the thrown operation within an implicit conversion to System.Exception type.
// We also want to walk down explicit conversions such as "throw (Exception)new ArgumentNullException())".
if (thrownObject is IConversionOperation conversion &&
conversion.IsImplicit)
conversion.Conversion.Exists)
{
thrownObject = conversion.Operand;
}
Expand Down