Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c559545
Move to latest .NET8 pre-release version of NetAnalyzers package for …
mavasani Dec 22, 2022
377e56c
Fix violations for CA1810: Initialize reference type static fields in…
mavasani Dec 22, 2022
e78f168
Suppress CA1000 violations in ConstantExpectedAnalyzer. Need to file …
mavasani Dec 22, 2022
81d9c7d
Suppress intentional CA1069 violation: Enums values should not be dup…
mavasani Dec 22, 2022
2044742
Fix CA1031 violations: Catch specific allow exception type
mavasani Dec 22, 2022
5811094
Suppress CA1040 violation: Avoid empty interfaces
mavasani Dec 22, 2022
89415bc
Fix CA1051 violations: Do not declare visible instance fields
mavasani Dec 22, 2022
863c5b5
Suppress CA1055 violation: URI-like return values should not be strings
mavasani Dec 22, 2022
302c60e
Supress CA1056 violation: URI-like properties should not be strings
mavasani Dec 22, 2022
aeda482
Suppress CA1305: Pass IFormatProvider in the repo. Need to file an is…
mavasani Dec 22, 2022
f7368f2
Suppress CA1308 violation: Use ToUpperInvariant instead of ToLowerInv…
mavasani Dec 22, 2022
200f81a
Fix CA1310 violations: Specify StringComparison
mavasani Dec 22, 2022
1f27689
Fix CA1725 violations: Parameter names for overrides should match the…
mavasani Dec 22, 2022
bb3a6e0
Fix CA1802 violations: Make field constant
mavasani Dec 22, 2022
368aef3
Fix CA1806 violation: Explicit disacard of return value from TryParse…
mavasani Dec 22, 2022
0556ba3
Suppress CA1815 violations for types not used for equality checks: Ov…
mavasani Dec 22, 2022
bc969aa
Fix CA1822 violations:: Make member static
mavasani Dec 22, 2022
5cc7177
Fix CA1825 violation: Avoid unnecessary zero-length array allocations
mavasani Dec 22, 2022
e52ac15
Suppress CA1848 violations (TODO: file an issue to track fixing viola…
mavasani Dec 22, 2022
8002776
Downgrade CA1851 (Possible multiple enumerations of 'IEnumerable' col…
mavasani Dec 22, 2022
c205e5b
Fixed additional CA1822 violation: Make member static
mavasani Dec 22, 2022
4541ace
Fix CA1852 violations: Seal internal types
mavasani Dec 22, 2022
48df63d
Fix CA1854 vilations: Prefer a 'TryGetValue' call over a Dictionary i…
mavasani Dec 22, 2022
9d75a7a
Fix CA2007 violations: Call ConfigureAwait on awaited task
mavasani Dec 22, 2022
a6438cb
Fix CA2208 violations: Pass message and paramName to ArgumentExceptio…
mavasani Dec 22, 2022
a4bd1a1
Fix CA2251 violations: Use 'string.Equals' instead of comparing the r…
mavasani Dec 22, 2022
00bad24
Suppress CA2254 violations: The logging message template should not v…
mavasani Dec 22, 2022
dc04897
Suppress CA1847 violations (retained for clarity): Use 'string.Contai…
mavasani Dec 22, 2022
cd01f06
Add tracking issue in comments
mavasani Dec 22, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CA1031 violations: Catch specific allow exception type
  • Loading branch information
mavasani committed Dec 22, 2022
commit 20447428f31d2dd1916f7944b55ba5761b371a51
Original file line number Diff line number Diff line change
Expand Up @@ -233,14 +233,18 @@ private static bool TryConvertSignedInteger(object constant, out long integer)

integer = Convert.ToInt64(constant);
}
catch
catch (Exception ex) when (CatchExceptionDuringConvert(ex))
{
integer = default;
return false;
}

return true;
}

private static bool CatchExceptionDuringConvert(Exception ex)
=> ex is FormatException or InvalidCastException or OverflowException or ArgumentNullException;

private static bool TryConvertUnsignedInteger(object constant, out ulong integer)
{
try
Expand All @@ -253,7 +257,7 @@ private static bool TryConvertUnsignedInteger(object constant, out ulong integer

integer = Convert.ToUInt64(constant);
}
catch
catch (Exception ex) when (CatchExceptionDuringConvert(ex))
{
integer = default;
return false;
Expand Down Expand Up @@ -306,7 +310,7 @@ private static bool TryTransformChar(object constant, out char value, out bool i

value = Convert.ToChar(constant);
}
catch
catch (Exception ex) when (CatchExceptionDuringConvert(ex))
{
return Invalid(out value, out isInvalid);
}
Expand Down