Remove duplicate lock DocumentState.s_syntaxTreeToIdMapLock #19266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
approved these changes
May 4, 2017
Member
There was a problem hiding this comment.
Any reason not to use GetValue? Last time I did a pattern like this @KirillOsenkov never let me live it down.
Contributor
Author
There was a problem hiding this comment.
No, a definite oversight on my part.
This lock is only being used to protect access to an instance which contains internal synchronization.
sharwell
force-pushed
the
rm-documentid-lock
branch
from
d4534f5 to
29ac030
Compare
Contributor
Author
|
@Pilchie for 15.7 pre-ask mode |
Member
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lock is only being used to protect access to an instance which contains
internal synchronization.