Skip to content

Conversation

@heejaechang
Copy link
Contributor

it is asked from service hub team so that they can more easily identify which team owns which service.

Customer scenario

this is not user visible change

Bugs this fixes

#22970

Workarounds, if any

no workaround

Risk

no risk

Performance impact

no performance impact

Is this a regression from a previous update?

N/A

Root cause analysis

our service hub service used too general term such as remote host service, snapshot service and etc which made it hard for others to find out which team owns the service.

How was the bug found?

dogfooding

it is asked from service hub team so that they can more easily identify which team owns which service.
@heejaechang heejaechang requested a review from a team as a code owner January 23, 2018 10:14
@heejaechang
Copy link
Contributor Author

@jinujoseph can you take a look?

@sharwell
Copy link
Contributor

@heejaechang Can you give an overview of how these changes can be observed? For example:

  • Where do the renamed files go in a Visual Studio installation?
  • Do the names of any child processes change?
  • Can this cause a problem for an F5 experience for Roslyn developers?
  • Any other observable differences?

@heejaechang
Copy link
Contributor Author

@sharwell

  • Where do the renamed files go in a Visual Studio installation?

this is servicehub service definition file. it will go where our VS.Setup.vsix puts Roslyn bits.

  • Do the names of any child processes change?

No

  • Can this cause a problem for an F5 experience for Roslyn developers?

No

  • Any other observable differences?

No

like I said, there is no user visible changes. except the first, those are user visible changes.

@heejaechang
Copy link
Contributor Author

@jinujoseph @AArnott do you want it to be 15.6? or it is fine to be 15.7?

@heejaechang heejaechang requested a review from a team as a code owner January 23, 2018 21:30
@heejaechang
Copy link
Contributor Author

turns out microbuild_prtest failure was valid one. the devdiv insertion tool had whitelist of files and that had old file names. updated devdiv insertion tool to new names.

@jinujoseph
Copy link
Contributor

We are technically in escrow for 15.6 , so i am ok to take this for 15.7 , unless @AArnott has a strong reason to take for 15.6

@AArnott
Copy link
Contributor

AArnott commented Jan 23, 2018

15.7 is fine. It's a long-term concern that your service names were not sufficiently unique as to both be identified as roslyn and avoid collisions with someone else's similarly simply named service.

@heejaechang heejaechang changed the base branch from dev15.6.x to dev15.7.x January 24, 2018 00:07
@heejaechang
Copy link
Contributor Author

moving it to 15.7.x

@jinujoseph
Copy link
Contributor

@MattGertz for 15.7 approval

@MattGertz
Copy link
Contributor

Approved. Note that @Pilchie can approve these too.

@heejaechang heejaechang merged commit d2a7c26 into dotnet:dev15.7.x Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants