-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Renamed roslyn servicehub service names #24392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it is asked from service hub team so that they can more easily identify which team owns which service.
|
@jinujoseph can you take a look? |
|
@heejaechang Can you give an overview of how these changes can be observed? For example:
|
like I said, there is no user visible changes. except the first, those are user visible changes. |
|
@jinujoseph @AArnott do you want it to be 15.6? or it is fine to be 15.7? |
|
turns out microbuild_prtest failure was valid one. the devdiv insertion tool had whitelist of files and that had old file names. updated devdiv insertion tool to new names. |
|
We are technically in escrow for 15.6 , so i am ok to take this for 15.7 , unless @AArnott has a strong reason to take for 15.6 |
|
15.7 is fine. It's a long-term concern that your service names were not sufficiently unique as to both be identified as roslyn and avoid collisions with someone else's similarly simply named service. |
|
moving it to 15.7.x |
|
@MattGertz for 15.7 approval |
|
Approved. Note that @Pilchie can approve these too. |
it is asked from service hub team so that they can more easily identify which team owns which service.
Customer scenario
this is not user visible change
Bugs this fixes
#22970
Workarounds, if any
no workaround
Risk
no risk
Performance impact
no performance impact
Is this a regression from a previous update?
N/A
Root cause analysis
our service hub service used too general term such as remote host service, snapshot service and etc which made it hard for others to find out which team owns the service.
How was the bug found?
dogfooding