Small cleanup of completion logic. #24541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
tagging @dotnet/roslyn-ide Tiny review plz |
sharwell
approved these changes
Jan 30, 2018
jasonmalinowski
approved these changes
Jan 30, 2018
Member
|
@jinujoseph Should we move this to 15.7? |
jinujoseph
approved these changes
Jan 31, 2018
Contributor
|
yes, i think make sense to take it for 15.7 @Pilchie for ask mode pre-approval before we retarget |
Member
|
I'm fine with 15.7 for this. |
Contributor
|
@CyrusNajmabadi Let me know if you want me to rebase this for you or if you'd like to do it yourself. The target branch is dev15.7.x. 😄 |
Member
Author
|
i appear to have done something terrible. help would be appreciated. |
Member
|
@CyrusNajmabadi I think you just want to cherry-pick 836f6546a55b34470635d88c474d441d108e27f5 over to dev15.7.x, force this branch to the resulting commit, and force-push. |
Contributor
|
I'll go ahead and rebase now (edit: done) |
sharwell
force-pushed
the
completionCleanup
branch
from
836f654 to
a648ffc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking at this code to make sure we didn't have any issues where we wouldn't offer "System.Enum" in a constraint clause. Noticed it was doing things that seemed unnecessary (And were likely holdovers from days when we used IEnumerable).