Make the variables constants.

[AdamSpeight2008]

Fix for Issue #27189

[sharwell]

I prefer static readonly to const for non-private fields in C# code, but this is Visual Basic and also other people on the team may disagree. Before we make a change here let me talk to the team on Monday to reach a conclusion.

[AdamSpeight2008]

@sharwell I prefer Const in this context, as the value of those string are highly unlikely to change anytime soon. IMHO. It's here if needed.

[AdamSpeight2008]

Side Note: The colour of Await and Yield are incorrect, should be black in this context.

[CyrusNajmabadi]

can we use shared-readonly instead?

[sharwell]

➡️ As I mentioned above, this is currently the subject of an open design discussion which we'll make a decision on and report back. To avoid unnecessary back and forth it didn't make sense to request a change until the design review reaches a conclusion.

[sharwell]

This went to a design meeting yesterday. Since the impacted code did not fall into the public API surface (even though IVTs are potentially impacted), we did not reach a final conclusion regarding an expected pattern future developers are supposed to follow.

We therefore reviewed this as a refactoring operation without clear guidance on the 'one right way' to proceed. Since the old code unexpectedly defined the fields as mutable, we felt that a change to Const is a clear improvement to the overall code quality and thus justifies the inclusion of the change even though we don't have specific guidance.

[jinujoseph]

Approved to merge for 15.8.Preview3

[AdamSpeight2008]

@sharwell What does IVTs mean? as it a new acronym to me.

[jinujoseph]

IVT => Internal Visible True