Skip to content

Conversation

@dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into features/embeddedJson.

git fetch --all
git checkout merges/master-to-features/embeddedJson
git reset --hard upstream/features/embeddedJson
git merge upstream/master
# Fix merge conflicts
git commit
git push merges/master-to-features/embeddedJson --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

…names searches. (#26331)

Followup to #26325 and #26330. This PR updates the IDE to forward certain helpers to these more efficient implementations.

This helps things out by more quickly being able to determine if a type even contains a member with name, and thus whether or not it should even be hydrated into a symbol and have its members created. Previous we would have to do a linear scan on all the members in a type to determine this. Now this data is in a set which can be queried much more efficiently.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit d5ebbc2 into features/embeddedJson May 31, 2018
@ghost ghost deleted the merges/master-to-features/embeddedJson branch May 31, 2018 18:30
@dotnet-bot dotnet-bot restored the merges/master-to-features/embeddedJson branch May 31, 2018 18:48
@dotnet-bot dotnet-bot deleted the merges/master-to-features/embeddedJson branch May 31, 2018 18:48
@dotnet-bot dotnet-bot restored the merges/master-to-features/embeddedJson branch May 31, 2018 19:00
@dotnet-bot dotnet-bot deleted the merges/master-to-features/embeddedJson branch May 31, 2018 19:00
@dotnet-bot dotnet-bot restored the merges/master-to-features/embeddedJson branch May 31, 2018 20:00
@dotnet-bot dotnet-bot deleted the merges/master-to-features/embeddedJson branch May 31, 2018 20:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants