Skip to content

Handle failed SaveAsync operations #51244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharwell merged 2 commits into from
Feb 19, 2021
Merged

Handle failed SaveAsync operations #51244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a7ff2e
Handle failed SaveAsync operations
sharwell Feb 16, 2021
2455535
Link to dotnet/runtime#30878 instead of dotnet/roslyn#42178
sharwell Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Link to dotnet/runtime#30878 instead of #42178
  • Loading branch information
@sharwell
sharwell committed Feb 16, 2021
commit 2455535bd806c960726a8d1d9b5396b78e526b80
2 changes: 1 addition & 1 deletion src/Workspaces/Core/Portable/TemporaryStorage/TemporaryStorageServiceFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public IWorkspaceService CreateService(HostWorkspaceServices workspaceServices)

// MemoryMapped files which are used by the TemporaryStorageService are present in .NET Framework (including Mono)
// and .NET Core Windows. For non-Windows .NET Core scenarios, we can return the TrivialTemporaryStorageService
// until https://github.com/dotnet/roslyn/issues/42178 is fixed.
// until https://github.com/dotnet/runtime/issues/30878 is fixed.
return PlatformInformation.IsWindows || PlatformInformation.IsRunningOnMono
? (ITemporaryStorageService)new TemporaryStorageService(textFactory)
: TrivialTemporaryStorageService.Instance;
Expand Down