Skip to content

Fix usernames in area-owners.md [features/dont-build-docs-changes] #58716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Youssef1313 wants to merge 2 commits into from
Closed

Fix usernames in area-owners.md [features/dont-build-docs-changes] #58716

Youssef1313 wants to merge 2 commits into from

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jan 7, 2022

No description provided.

@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-Compilers labels Jan 7, 2022
@Youssef1313
Copy link
Member Author

Youssef1313 commented Jan 7, 2022

@RikkiGibson @jaredpar

@Youssef1313 Youssef1313 mentioned this pull request Jan 7, 2022
Closed
RikkiGibson
RikkiGibson previously approved these changes Jan 7, 2022
View reviewed changes
@RikkiGibson
Copy link
Member

RikkiGibson commented Jan 7, 2022

I see the following

image

Basically, it seems the proper status is now reported to GitHub and we get a green merge button without having to run the CI jobs 😊 This should mean that we can merge the config change from this feature branch over to main and actually skip running CI on doc changes from now on. cc @jmarolf

@RikkiGibson
Copy link
Member

RikkiGibson commented Jan 7, 2022

@Youssef1313 feel free to reopen #58712 targeting main and we'll consider the "feature" completed 😉

@Youssef1313 Youssef1313 mentioned this pull request Jan 7, 2022
Merged
@RikkiGibson
Copy link
Member

RikkiGibson commented Jan 7, 2022

Sorry, one more thing @Youssef1313. Could you please try pushing a non-doc change to this PR and let's verify that the CI gets run as expected.

@Youssef1313 Youssef1313 requested a review from a team as a code owner January 7, 2022 21:18
@RikkiGibson RikkiGibson dismissed their stale review January 7, 2022 21:24

shouldn't merge

@jasonmalinowski
Copy link
Member

jasonmalinowski commented Jan 7, 2022

(signing off but don't treat my signoff as meaning anything to the fight we're having with CI)

@RikkiGibson
Copy link
Member

RikkiGibson commented Jan 8, 2022

We opened this PR to verify behavior of #58723. Now that we've merged that, we don't need this PR any more.

@RikkiGibson RikkiGibson closed this Jan 8, 2022
@Youssef1313 Youssef1313 deleted the patch-9 branch January 8, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@RikkiGibson RikkiGibson RikkiGibson left review comments

Assignees

No one assigned

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Youssef1313 @RikkiGibson @jasonmalinowski