Revert "Apply changes directly to text buffer (#62337)" #62589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
genlu
approved these changes
Jul 13, 2022
Member
|
What was the issue here? |
Member
|
@tmat mentioned there is a post-processing step in ContainedDocument that cleans the buffers up after any changes to the buffer. |
Member
Author
|
Working on a fix. |
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jul 13, 2022
…dotnet#62589)" This reverts commit 0a39dcf.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jul 13, 2022
…dotnet#62589)" This reverts commit 0a39dcf.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jul 14, 2022
…dotnet#62589)" This reverts commit 0a39dcf.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jul 14, 2022
…dotnet#62589)" This reverts commit 0a39dcf.
tmat
added a commit
that referenced
this pull request
Jul 18, 2022
adamperlin
pushed a commit
to adamperlin/roslyn
that referenced
this pull request
Jul 19, 2022
adamperlin
pushed a commit
to adamperlin/roslyn
that referenced
this pull request
Jul 19, 2022
* Revert "Revert "Apply changes directly to text buffer (dotnet#62337)" (dotnet#62589)" This reverts commit 0a39dcf. * Apply changes to ContainedDocument subject buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 002abc1.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1568401