Revert "Revert "Generalize RoamingProfileStorageLocation to ClientSettingsStorageLocation (#62684)"" #62759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tingsStorageLocation (dotnet#62684)"" This reverts commit 9c68f9b.
ghost
added
the
genlu
approved these changes
Jul 19, 2022
genlu
approved these changes
Jul 27, 2022
Member
genlu
left a comment
genlu
left a comment
There was a problem hiding this comment.
The issue with IndexingService is now fixed pending insertion.
https://devdiv.visualstudio.com/DevDiv/_git/VS-Platform/pullrequest/413466
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jul 29, 2022
…tingsStorageLocation (dotnet#62684)"" (dotnet#62759) This reverts commit 9c68f9b.
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jan 12, 2023
We regressed a few VB editor options in 17.4 (PR: dotnet#62759) when we switched reading these options from IVsTextManagerEvents4 to ISettingsManager API. - formatting: "Use Tabs", "Indent Size", "Tab Size". "Smart Indent", - statement completion: "Auto list members", "Hide advanced members", "Parameter information", - settings: "Navigation bar" We don't read their values for VS settings correctly for VB because we use language name "VisualBasic" while the editor uses "Basic" in the option storage name. This does not affect other languages (C#, F#).
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jan 12, 2023
We regressed a few VB editor options in 17.4 (PR: dotnet#62759) when we switched reading these options from IVsTextManagerEvents4 to ISettingsManager API. - formatting: "Use Tabs", "Indent Size", "Tab Size". "Smart Indent", - statement completion: "Auto list members", "Hide advanced members", "Parameter information", - settings: "Navigation bar" We don't read their values for VS settings correctly for VB because we use language name "VisualBasic" while the editor uses "Basic" in the option storage name. This does not affect other languages (C#, F#).
tmat
added a commit
to tmat/roslyn
that referenced
this pull request
Jan 12, 2023
We regressed a few VB editor options in 17.4 (PR: dotnet#62759) when we switched reading these options from IVsTextManagerEvents4 to ISettingsManager API. - formatting: "Use Tabs", "Indent Size", "Tab Size". "Smart Indent", - statement completion: "Auto list members", "Hide advanced members", "Parameter information", - settings: "Navigation bar" We don't read their values for VS settings correctly for VB because we use language name "VisualBasic" while the editor uses "Basic" in the option storage name. This does not affect other languages (C#, F#).
tmat
added a commit
that referenced
this pull request
Jan 17, 2023
We regressed a few VB editor options in 17.4 (PR: #62759) when we switched reading these options from IVsTextManagerEvents4 to ISettingsManager API. - formatting: "Use Tabs", "Indent Size", "Tab Size". "Smart Indent", - statement completion: "Auto list members", "Hide advanced members", "Parameter information", - settings: "Navigation bar" We don't read their values for VS settings correctly for VB because we use language name "VisualBasic" while the editor uses "Basic" in the option storage name. This does not affect other languages (C#, F#).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9c68f9b.
Based on @jasonmalinowski's analysis the RPS regression caused by the original PR is actually an improvement.