Skip to content

Make remaining managed pointer type scenarios warnings #64294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcouv merged 6 commits into from
Sep 30, 2022
Merged

Make remaining managed pointer type scenarios warnings #64294

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
85e5ecd
Make remaining managed pointer type scenarios warnings
Sep 23, 2022
39a1e43
Add LangVer check
Sep 29, 2022
43dfcdc
Revert "Add LangVer check"
Sep 29, 2022
dca4e15
Fix a test
Sep 29, 2022
0a1a2cc
Keep stackalloc scenario an error
Sep 29, 2022
4189162
Update tests
Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests
  • Loading branch information
Julien Couvreur committed Sep 30, 2022
commit 41891624af5da87a4eab3b194b2d8ec2884cc705
8 changes: 4 additions & 4 deletions src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1376,9 +1376,9 @@ unsafe void M()
// (8,20): error CS8346: Conversion of a stackalloc expression of type 'int' to type 'int*' is not possible.
// int* s3 = (stackalloc[] { 1 })!;
Diagnostic(ErrorCode.ERR_StackAllocConversionNotPossible, "stackalloc[] { 1 }").WithArguments("int", "int*").WithLocation(8, 20),
// (9,35): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('string')
// (9,35): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('string')
// System.Span<string> s4 = (stackalloc[] { null, string.Empty })!;
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc[] { null, string.Empty }").WithArguments("string").WithLocation(9, 35));
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc[] { null, string.Empty }").WithArguments("string").WithLocation(9, 35));
}

[Fact, WorkItem(31370, "https://github.com/dotnet/roslyn/issues/31370")]
Expand Down Expand Up @@ -156127,9 +156127,9 @@ struct D<T>
", options: TestOptions.UnsafeDebugDll);

comp.VerifyDiagnostics(
// (7,11): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('D<object>')
// (7,11): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('D<object>')
// var a = stackalloc[] { M(o) };
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc[] { M(o) }").WithArguments("D<object>").WithLocation(7, 11),
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc[] { M(o) }").WithArguments("D<object>").WithLocation(7, 11),
// (15,14): warning CS0649: Field 'D<T>.Item' is never assigned to, and will always have its default value
// public T Item;
Diagnostic(ErrorCode.WRN_UnassignedInternalField, "Item").WithArguments("D<T>.Item", "").WithLocation(15, 14)
Expand Down
67 changes: 32 additions & 35 deletions src/Compilers/CSharp/Test/Semantic/Semantics/StackAllocInitializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,9 @@ unsafe void M()
", TestOptions.UnsafeReleaseDll);

comp.VerifyDiagnostics(
// (10,29): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('RefG<string>')
// (10,29): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('RefG<string>')
// var x2 = stackalloc RefG<string>[10];
Diagnostic(ErrorCode.WRN_ManagedAddr, "RefG<string>").WithArguments("RefG<string>").WithLocation(10, 29),
Diagnostic(ErrorCode.ERR_ManagedAddr, "RefG<string>").WithArguments("RefG<string>").WithLocation(10, 29),
// (16,22): error CS0611: Array elements cannot be of type 'RefS'
// var y1 = new RefS[10];
Diagnostic(ErrorCode.ERR_ArrayElementCantBeRefAny, "RefS").WithArguments("RefS").WithLocation(16, 22),
Expand Down Expand Up @@ -151,15 +151,15 @@ public struct ValueTuple<T1, T2> {
// (13,18): error CS0826: No best type found for implicitly-typed array
// var p4 = stackalloc[] { (1, null) };
Diagnostic(ErrorCode.ERR_ImplicitlyTypedArrayNoBestType, "stackalloc[] { (1, null) }").WithLocation(13, 18),
// (14,18): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('Action')
// (14,18): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('Action')
// var p5 = stackalloc[] { () => { } };
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc[] { () => { } }").WithArguments("System.Action").WithLocation(14, 18),
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc[] { () => { } }").WithArguments("System.Action").WithLocation(14, 18),
// (15,18): error CS0826: No best type found for implicitly-typed array
// var p6 = stackalloc[] { new {} , new { i = 0 } };
Diagnostic(ErrorCode.ERR_ImplicitlyTypedArrayNoBestType, "stackalloc[] { new {} , new { i = 0 } }").WithLocation(15, 18),
// (16,18): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
// (16,18): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// var p7 = stackalloc[] { d };
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc[] { d }").WithArguments("dynamic").WithLocation(16, 18),
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc[] { d }").WithArguments("dynamic").WithLocation(16, 18),
// (17,33): error CS0103: The name '_' does not exist in the current context
// var p8 = stackalloc[] { _ };
Diagnostic(ErrorCode.ERR_NameNotInContext, "_").WithArguments("_").WithLocation(17, 33)
Expand Down Expand Up @@ -213,15 +213,15 @@ public struct ValueTuple<T1, T2> {
// (13,32): error CS0826: No best type found for implicitly-typed array
// var p4 = c ? default : stackalloc[] { (1, null) };
Diagnostic(ErrorCode.ERR_ImplicitlyTypedArrayNoBestType, "stackalloc[] { (1, null) }").WithLocation(13, 32),
// (14,32): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('Action')
// (14,32): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('Action')
// var p5 = c ? default : stackalloc[] { () => { } };
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc[] { () => { } }").WithArguments("System.Action").WithLocation(14, 32),
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc[] { () => { } }").WithArguments("System.Action").WithLocation(14, 32),
// (15,32): error CS0826: No best type found for implicitly-typed array
// var p6 = c ? default : stackalloc[] { new {} , new { i = 0 } };
Diagnostic(ErrorCode.ERR_ImplicitlyTypedArrayNoBestType, "stackalloc[] { new {} , new { i = 0 } }").WithLocation(15, 32),
// (16,32): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
// (16,32): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// var p7 = c ? default : stackalloc[] { d };
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc[] { d }").WithArguments("dynamic").WithLocation(16, 32),
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc[] { d }").WithArguments("dynamic").WithLocation(16, 32),
// (17,47): error CS0103: The name '_' does not exist in the current context
// var p8 = c ? default : stackalloc[] { _ };
Diagnostic(ErrorCode.ERR_NameNotInContext, "_").WithArguments("_").WithLocation(17, 47)
Expand Down Expand Up @@ -350,12 +350,12 @@ void Method1(S s)
}", TestOptions.UnsafeReleaseDll);

comp.VerifyDiagnostics(
// (7,20): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('string')
// (7,20): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('string')
// var obj1 = stackalloc[] { "" };
Diagnostic(ErrorCode.WRN_ManagedAddr, @"stackalloc[] { """" }").WithArguments("string").WithLocation(7, 20),
// (8,20): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('<empty anonymous type>')
Diagnostic(ErrorCode.ERR_ManagedAddr, @"stackalloc[] { """" }").WithArguments("string").WithLocation(7, 20),
// (8,20): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('<empty anonymous type>')
// var obj2 = stackalloc[] { new {} };
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc[] { new {} }").WithArguments("<empty anonymous type>").WithLocation(8, 20)
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc[] { new {} }").WithArguments("<empty anonymous type>").WithLocation(8, 20)
);

var tree = comp.SyntaxTrees.Single();
Expand Down Expand Up @@ -423,12 +423,12 @@ void Method1(S s, bool c)
}", TestOptions.UnsafeReleaseDll);

comp.VerifyDiagnostics(
// (7,34): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('string')
// (7,34): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('string')
// var obj1 = c ? default : stackalloc[] { "" };
Diagnostic(ErrorCode.WRN_ManagedAddr, @"stackalloc[] { """" }").WithArguments("string").WithLocation(7, 34),
// (8,34): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('<empty anonymous type>')
Diagnostic(ErrorCode.ERR_ManagedAddr, @"stackalloc[] { """" }").WithArguments("string").WithLocation(7, 34),
// (8,34): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('<empty anonymous type>')
// var obj2 = c ? default : stackalloc[] { new {} };
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc[] { new {} }").WithArguments("<empty anonymous type>").WithLocation(8, 34),
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc[] { new {} }").WithArguments("<empty anonymous type>").WithLocation(8, 34),
// (9,34): error CS0306: The type 'Test.S' may not be used as a type argument
// var obj3 = c ? default : stackalloc[] { s };
Diagnostic(ErrorCode.ERR_BadTypeArgument, "stackalloc[] { s }").WithArguments("Test.S").WithLocation(9, 34)
Expand Down Expand Up @@ -876,9 +876,9 @@ public void Method1()
}", TestOptions.UnsafeReleaseDll);

comp.VerifyDiagnostics(
// (6,31): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('int[]')
// (6,31): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('int[]')
// var obj1 = stackalloc int[][] { 1 };
Diagnostic(ErrorCode.WRN_ManagedAddr, "int").WithArguments("int[]").WithLocation(6, 31),
Diagnostic(ErrorCode.ERR_ManagedAddr, "int").WithArguments("int[]").WithLocation(6, 31),
// (6,31): error CS1575: A stackalloc expression requires [] after type
// var obj1 = stackalloc int[][] { 1 };
Diagnostic(ErrorCode.ERR_BadStackAllocExpr, "int[][]").WithLocation(6, 31)
Expand Down Expand Up @@ -1792,21 +1792,18 @@ static void Main()
var d3 = stackalloc [ ] { d };
}
}").VerifyDiagnostics(
// (7,29): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
// (7,29): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// var d1 = stackalloc dynamic [3] { d };
Diagnostic(ErrorCode.WRN_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(7, 29),
Diagnostic(ErrorCode.ERR_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(7, 29),
// (7,18): error CS0847: An array initializer of length '3' is expected
// var d1 = stackalloc dynamic [3] { d };
Diagnostic(ErrorCode.ERR_ArrayInitializerIncorrectLength, "stackalloc dynamic [3] { d }").WithArguments("3").WithLocation(7, 18),
// (8,29): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
// (8,29): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// var d2 = stackalloc dynamic [ ] { d };
Diagnostic(ErrorCode.WRN_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(8, 29),
// (8,18): error CS0214: Pointers and fixed size buffers may only be used in an unsafe context
// var d2 = stackalloc dynamic [ ] { d };
Diagnostic(ErrorCode.ERR_UnsafeNeeded, "stackalloc dynamic [ ] { d }").WithLocation(8, 18),
// (9,18): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
Diagnostic(ErrorCode.ERR_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(8, 29),
// (9,18): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// var d3 = stackalloc [ ] { d };
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc [ ] { d }").WithArguments("dynamic").WithLocation(9, 18),
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc [ ] { d }").WithArguments("dynamic").WithLocation(9, 18),
// (9,18): error CS0214: Pointers and fixed size buffers may only be used in an unsafe context
// var d3 = stackalloc [ ] { d };
Diagnostic(ErrorCode.ERR_UnsafeNeeded, "stackalloc [ ] { d }").WithLocation(9, 18)
Expand All @@ -1828,18 +1825,18 @@ static void Main()
Span<dynamic> d3 = stackalloc [ ] { d };
}
}").VerifyDiagnostics(
// (8,39): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
// (8,39): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// Span<dynamic> d1 = stackalloc dynamic [3] { d };
Diagnostic(ErrorCode.WRN_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(8, 39),
Diagnostic(ErrorCode.ERR_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(8, 39),
// (8,28): error CS0847: An array initializer of length '3' is expected
// Span<dynamic> d1 = stackalloc dynamic [3] { d };
Diagnostic(ErrorCode.ERR_ArrayInitializerIncorrectLength, "stackalloc dynamic [3] { d }").WithArguments("3").WithLocation(8, 28),
// (9,39): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
// (9,39): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// Span<dynamic> d2 = stackalloc dynamic [ ] { d };
Diagnostic(ErrorCode.WRN_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(9, 39),
// (10,28): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
Diagnostic(ErrorCode.ERR_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(9, 39),
// (10,28): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// Span<dynamic> d3 = stackalloc [ ] { d };
Diagnostic(ErrorCode.WRN_ManagedAddr, "stackalloc [ ] { d }").WithArguments("dynamic").WithLocation(10, 28)
Diagnostic(ErrorCode.ERR_ManagedAddr, "stackalloc [ ] { d }").WithArguments("dynamic").WithLocation(10, 28)
);
}

Expand Down
11 changes: 4 additions & 7 deletions src/Compilers/CSharp/Test/Semantic/Semantics/StackAllocSpanExpressionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,12 +608,9 @@ static void Main()
var d = stackalloc dynamic[10];
}
}").VerifyDiagnostics(
// (6,17): error CS0214: Pointers and fixed size buffers may only be used in an unsafe context
// var d = stackalloc dynamic[10];
Diagnostic(ErrorCode.ERR_UnsafeNeeded, "stackalloc dynamic[10]").WithLocation(6, 17),
// (6,28): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
// (6,28): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// var d = stackalloc dynamic[10];
Diagnostic(ErrorCode.WRN_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(6, 28)
Diagnostic(ErrorCode.ERR_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(6, 28)
);
}

Expand All @@ -629,9 +626,9 @@ static void Main()
Span<dynamic> d = stackalloc dynamic[10];
}
}").VerifyDiagnostics(
// (7,38): warning CS8500: This takes the address of, gets the size of, or declares a pointer to a managed type ('dynamic')
// (7,38): error CS0208: Cannot take the address of, get the size of, or declare a pointer to a managed type ('dynamic')
// Span<dynamic> d = stackalloc dynamic[10];
Diagnostic(ErrorCode.WRN_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(7, 38)
Diagnostic(ErrorCode.ERR_ManagedAddr, "dynamic").WithArguments("dynamic").WithLocation(7, 38)
);
}

Expand Down
Loading