Skip to content

Change ForAttributeWithMetadataName to use an explicit stack when recursing #64322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 4 commits into from
Sep 29, 2022
Merged

Change ForAttributeWithMetadataName to use an explicit stack when recursing #64322

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6abea58
Change ForAttributeWithMetadataName to use an explicit stack when rec…
CyrusNajmabadi Sep 27, 2022
5aa3df8
Update src/Compilers/Core/Portable/SourceGeneration/Nodes/SyntaxValue…
CyrusNajmabadi Sep 28, 2022
cf119b0
Cleanup
CyrusNajmabadi Sep 28, 2022
573df10
Merge branch 'fawmnOverflow' of https://github.com/CyrusNajmabadi/ros…
CyrusNajmabadi Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rs/Core/Portable/SourceGeneration/Nodes/SyntaxValueProvider_ForAttributeWithSimpleName.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ internal enum SourceGeneratorSyntaxTreeInfo

public partial struct SyntaxValueProvider
{
private static readonly ObjectPool<Stack<string>> s_stringStackPool = new(static () => new());
private static readonly ObjectPool<Stack<SyntaxNode>> s_nodeStackPool = new(static () => new());
private static readonly ObjectPool<Stack<string>> s_stringStackPool = new ObjectPool<Stack<string>>(static () => new Stack<string>());
private static readonly ObjectPool<Stack<SyntaxNode>> s_nodeStackPool = new ObjectPool<Stack<SyntaxNode>>(static () => new Stack<SyntaxNode>());

/// <summary>
/// Returns all syntax nodes of that match <paramref name="predicate"/> if that node has an attribute on it that
Expand Down