Skip to content

Fix Color Contrast For STE Close Button #64834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryzngard merged 1 commit into from
Oct 19, 2022
Merged

Fix Color Contrast For STE Close Button #64834

ryzngard merged 1 commit into from
Oct 19, 2022

Conversation

@ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Oct 19, 2022 •
edited
Loading

Fixes AB#1625997

Dark Theme

ba54cdf6-d3f2-4929-8d65-44caa4d4c843

Light Theme

18e80fe0-dbc1-4ba5-9028-396b20506c05

@ryzngard ryzngard requested a review from a team as a code owner October 19, 2022 21:03
@ryzngard ryzngard added UX Review Not Required UX Review Not Required and removed Needs UX Triage labels Oct 19, 2022
@JoeRobich
Copy link
Member

JoeRobich commented Oct 19, 2022

got screenshots of this change?

@ryzngard
Copy link
Contributor Author

ryzngard commented Oct 19, 2022

got screenshots of this change?

Yup! Forgot to add to initial description. Added

JoeRobich
JoeRobich approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That has better contrast.

@ryzngard ryzngard merged commit 719f821 into dotnet:main Oct 19, 2022
@ryzngard ryzngard deleted the ste/close_button_color_contrast branch October 19, 2022 22:33
@ghost ghost added this to the Next milestone Oct 19, 2022
@allisonchou allisonchou mentioned this pull request Oct 22, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees

No one assigned

Labels

Area-IDE UX Review Not Required UX Review Not Required

Projects

None yet

Milestone

17.5 P1

Development

Successfully merging this pull request may close these issues.

3 participants

@ryzngard @JoeRobich @RikkiGibson