Skip to content

Do not register task list analyzer if solution-crawler is explicitly off #67045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 1 commit into from
Feb 25, 2023
Merged

Do not register task list analyzer if solution-crawler is explicitly off #67045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/VisualStudio/Core/Def/TaskList/VisualStudioTaskListService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ private async Task StartAsync(VisualStudioWorkspace workspace)
_ = new VisualStudioTaskListTable(workspace, _threadingContext, _tableManagerProvider, this);

// Now that we've hooked everything up, kick off the work to actually start computing and reporting items.
RegisterIncrementalAnalayzerAndStartComputingTaskListItems();
RegisterIncrementalAnalyzerAndStartComputingTaskListItems();
}
catch (OperationCanceledException)
{
Expand Down Expand Up @@ -149,13 +149,17 @@ public ImmutableArray<TaskListItem> GetTaskListItems(Workspace workspace, Docume
? values
: ImmutableArray<TaskListItem>.Empty;

private void RegisterIncrementalAnalayzerAndStartComputingTaskListItems()
private void RegisterIncrementalAnalyzerAndStartComputingTaskListItems()
{
// If we're in pull-diagnostics mode, then todo-comments will be handled by LSP.
var diagnosticMode = _globalOptions.GetDiagnosticMode();
if (diagnosticMode == DiagnosticMode.LspPull)
return;

// Do not register if solution crawler is explicitly off.
if (!_globalOptions.GetOption(SolutionCrawlerRegistrationService.EnableSolutionCrawler))
return;

var services = _workspace.Services.SolutionServices;
var registrationService = services.GetRequiredService<ISolutionCrawlerRegistrationService>();
var analyzerProvider = new TaskListIncrementalAnalyzerProvider(_globalOptions, this);
Expand Down