Skip to content

Add support for System.Diagnostics.CodeAnalysis.ExperimentalAttribute #68702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcouv merged 8 commits into from
Jul 6, 2023
Merged

Add support for System.Diagnostics.CodeAnalysis.ExperimentalAttribute #68702

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
58f7312
Add support for ExperimentalAttribute
Jun 18, 2023
eb8b887
Rename
Jun 20, 2023
4b36e8b
Add test
Jun 21, 2023
2608051
formatting
Jun 21, 2023
1b61429
Address feedback
Jun 22, 2023
1226862
Address feedback
Jul 5, 2023
38dbb3f
Address feedback
Jul 6, 2023
bddcfb3
Error format
Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting
  • Loading branch information
Julien Couvreur committed Jun 21, 2023
commit 2608051aac1f37fbcc1a7a81ae51fd0e44d84c7f
10 changes: 5 additions & 5 deletions src/Compilers/CSharp/Test/Emit2/Semantics/ExperimentalAttributeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ public ExperimentalAttribute(int diagnosticId)
C.M();
""";

var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference()});
var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference() });
comp.VerifyDiagnostics();
}

Expand Down Expand Up @@ -588,7 +588,7 @@ public ExperimentalAttribute(string diagnosticId) { }
C.M();
""";

var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference()});
var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference() });
comp.VerifyDiagnostics(
// (1,1): warning DiagID: 'C' is for evaluation purposes only and is subject to change or removal in future updates.
// C.M();
Expand Down Expand Up @@ -629,7 +629,7 @@ public ExperimentalAttribute(string diagnosticId) { }
C.M();
""";

var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference()});
var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference() });
comp.VerifyDiagnostics(
// (1,1): warning DiagID: 'C' is for evaluation purposes only and is subject to change or removal in future updates.
// C.M();
Expand Down Expand Up @@ -670,7 +670,7 @@ public ExperimentalAttribute(string diagnosticId) { }
C.M();
""";

var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference()});
var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference() });
comp.VerifyDiagnostics(
// (1,1): warning DiagID: 'C' is for evaluation purposes only and is subject to change or removal in future updates.
// C.M();
Expand Down Expand Up @@ -813,7 +813,7 @@ public ExperimentalAttribute(string diagnosticId) { }
C.M();
""";

var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference()});
var comp = CreateCompilation(src, references: new[] { libComp.EmitToImageReference() });
comp.VerifyDiagnostics(
// (1,1): warning DiagID: 'C' is for evaluation purposes only and is subject to change or removal in future updates.
// C.M();
Expand Down