Replace InterceptorsPreview with InterceptorsPreviewNamespaces=global #69848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
cston
reviewed
Sep 12, 2023
| comp = CreateCompilation(new[] { (source, "Program.cs"), s_attributesSource }, parseOptions: TestOptions.Regular.WithFeature("interceptorspreview")); | ||
| comp.VerifyEmitDiagnostics(sadCaseDiagnostics); | ||
|
|
||
| verifier = CompileAndVerify(new[] { (source, "Program.cs"), s_attributesSource }, parseOptions: TestOptions.Regular.WithFeature("interceptorspreview"), expectedOutput: "1"); |
Contributor
cston
approved these changes
Sep 12, 2023
Member
Author
|
@dotnet/roslyn-compiler for second review |
jjonescz
approved these changes
Sep 15, 2023
Member
You should be good to go. We merged the change to move to granular opt-in in the SDK last week. cc: @layomia to make sure the correct things have been done for nupkg for the config binder. |
captainsafia
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to completely remove the ability to declare interceptors in the global namespace and the test churn was just too much :)
Goal of the PR is to push people as much as possible toward granular opt-in while leaving in an undocumented global enable for expediency.