-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Null-conditional assignment 1 #75821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RikkiGibson
merged 28 commits into
dotnet:features/null-conditional-assignment
from
RikkiGibson:nca-1
Nov 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e85549e
WIP
RikkiGibson 0c8e4e3
more
RikkiGibson 58732d1
more tests
RikkiGibson 7034a9c
more
RikkiGibson d34ec44
more
RikkiGibson e38f10a
Merge remote-tracking branch 'upstream/main' into nca-1
RikkiGibson 2407ca7
fix parsing of shift assignment operators
RikkiGibson 9bb2cbd
more
RikkiGibson c74c892
Move local functions
RikkiGibson d69c43d
Merge branch 'nca-1' into nca-2
RikkiGibson b63590d
fix formatting
RikkiGibson c30f371
Merge remote-tracking branch 'upstream/features/null-conditional-assi…
RikkiGibson f4f7e4d
rename feature
RikkiGibson 40afde7
update comments
RikkiGibson 94323a0
fix parsing hang and tests
RikkiGibson 48372a9
fix parsing baseline
RikkiGibson c6f7bd0
Merge remote-tracking branch 'upstream/features/null-conditional-assi…
RikkiGibson cb6f02f
reimplement
RikkiGibson d7c7847
fix
RikkiGibson 995929c
more
RikkiGibson d199e32
more
RikkiGibson 461cad5
more
RikkiGibson d736db9
Update src/Compilers/CSharp/Test/Semantic/Semantics/NullConditionalAs…
RikkiGibson 338c771
Add some suggested tests
RikkiGibson ae47f70
use more theories
RikkiGibson 43e53fc
adjust langversion check and add test
RikkiGibson 50a309d
adjust LangVersion location
RikkiGibson a37fbde
Update src/Compilers/CSharp/Portable/Parser/LanguageParser.cs
RikkiGibson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix
- Loading branch information
commit d7c784726a772da8b6fda5b6cf5d021fd8a1ff88
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a reset point lets us unify the "check" and "act" steps of deciding to include the '!'s we found in the current cond-access node or not. This lets us avoid having to write a "dry-run" version of the assignment operator parsing code, which advances the token stream and potentially merges tokens found in it.