Extract local functions to members #75837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
RikkiGibson
commented
Nov 8, 2024
| private AssignmentExpressionSyntax ParseAssignmentOperator(SyntaxKind operatorExpressionKind, ExpressionSyntax leftOperand, SyntaxToken operatorToken) | ||
| { | ||
| Debug.Assert(IsExpectedAssignmentOperator(operatorToken.Kind)); | ||
| Debug.Assert(GetPrecedence(operatorExpressionKind) == Precedence.Assignment); |
Member
Author
There was a problem hiding this comment.
Instead of passing newPrecedence down thru here, we know it will always be Precedence.Assignment, so we just use that.
RikkiGibson
commented
Nov 8, 2024
| // well as `switch` and `with` clauses. | ||
|
|
||
| var (operatorTokenKind, operatorExpressionKind) = getOperatorTokenAndExpressionKind(); | ||
| var (operatorTokenKind, operatorExpressionKind) = GetOperatorTokenAndExpressionKind(); |
Member
There was a problem hiding this comment.
i would change the names as i recommended. the pr will still be small in that case.
| return (SyntaxKind.None, SyntaxKind.None); | ||
| } | ||
|
|
||
| private SyntaxToken EatOperatorToken(SyntaxKind operatorTokenKind) |
Member
There was a problem hiding this comment.
EatExpressionOperatorToken
CyrusNajmabadi
approved these changes
Nov 8, 2024
cston
approved these changes
Nov 8, 2024
cston
approved these changes
Nov 8, 2024
AlekseyTs
approved these changes
Nov 8, 2024
| return _syntaxFactory.AssignmentExpression( | ||
| operatorExpressionKind, leftOperand, operatorToken, rhs); | ||
| } | ||
| return ParseAssignmentOperator(operatorExpressionKind, leftOperand, operatorToken); |
Member
There was a problem hiding this comment.
i missed this. we should call this ParseAssignmentExpression.
| } | ||
| } | ||
|
|
||
| private AssignmentExpressionSyntax ParseAssignmentOperator(SyntaxKind operatorExpressionKind, ExpressionSyntax leftOperand, SyntaxToken operatorToken) |
Member
There was a problem hiding this comment.
Rename to ParseAssignmentExpression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75554
Precedes #75821
This PR only extracts local functions and blocks to members, with minimal semantic changes. These members will be reused to implement assignment parsing within the conditional access consequence expression.