Skip to content

Conversation

@davidwengier
Copy link
Member

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2317372

Presumably something changed in Roslyn where encoding can be null now? 🤷‍♂️

@davidwengier davidwengier requested a review from a team as a code owner January 13, 2025 21:37
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 13, 2025
@davidwengier
Copy link
Member Author

Oh cool, the test failure is real, so presumably this change broke things: https://github.com/dotnet/roslyn/pull/74623/files#r1865988171

@jasonmalinowski @CyrusNajmabadi do you want a follow up issue to re-look at the DocumentState change?

@CyrusNajmabadi
Copy link
Member

@jasonmalinowski can yuo ptal :)

@jasonmalinowski jasonmalinowski self-requested a review January 15, 2025 02:10
@davidwengier
Copy link
Member Author

Running in to this in Razor, and it's been annoying me, so I'm going to merge this fix. If there is follow up, I'm very unlikely to be the right person to do the work anyway, so it wouldn't be in this PR regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants