Add Microsoft.CodeAnalysis.Contracts source package #76997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
2 tasks
tmat
changed the title
Member
Author
|
@dotnet/roslyn-ide @dotnet/roslyn-compiler PTAL |
Contributor
That sounds reasonable to me, for consistency with the current state. Then we can discuss separately whether to include the |
cston
approved these changes
Feb 4, 2025
tmat
force-pushed
the
ContractsSourcePackage
branch
2 times, most recently
from
820f4fe to
948d2ea
Compare
tmat
force-pushed
the
ContractsSourcePackage
branch
from
948d2ea to
32af181
Compare
jjonescz
approved these changes
Feb 11, 2025
| <Compile Include="$(MSBuildThisFileDirectory)NullableAttributes.cs" /> | ||
| <Compile Include="$(MSBuildThisFileDirectory)RequiredMemberAttribute.cs" /> | ||
| <Compile Include="$(MSBuildThisFileDirectory)SetsRequiredMembersAttribute.cs" /> | ||
| <Compile Include="$(MSBuildThisFileDirectory)ExceptionUtilities.cs" /> |
Member
There was a problem hiding this comment.
Why not include glob *.cs rather than explicitly including each file?
Member
Author
There was a problem hiding this comment.
Glob works but next time you edit the project VS screws it up :(.
Member
Author
There was a problem hiding this comment.
@JakeRadMSFT Can we get this fixed please? dotnet/project-system#6010
Working with shared projects in VS is such a PITA.
This was referenced Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package is intended to include a small number of essential contracts and polyfills used across Roslyn code base and in other Roslyn source packages (see #76937).
Introduction of this package simplifies the set of file links in Roslyn repository, makes it easier to apply Roslyn coding patterns across other related repositories (e.g. dotnet-watch, Razor, WebTools, Interactive Window, etc) and to use other Roslyn source packages in these repositories.
Moves all non-polyfill types to
Microsoft.CodeAnalysisnamespace (instead ofRoslyn.Utilities). This move makes these core types immediately available in all Roslyn types defined inMicrosoft.CodeAnalysisnamespace or a subnamespace.For
Contracttype, it avoids accidental mix-up withMicrosoft.Diagnostics.Contracts.Contracttype in non-VS layer, which doesn't benefit since it defines types underMicrosoft.VisualStudionamespace.TODO:
Contracttype is not currently available in Compiler layer (only Workspace and up). We can use#if !MICROSOFT_CODEANALYSIS_CONTRACTS_NO_CONTRACTto keep it that way if desired.ExceptionUtilities.UnreachableandExceptionUtilities.UnexpectedValuemethods toContracttype. These helpers declare code contracts/assertions similar to those expressed byThrow*methods inContractclass.