Set the default namespace for the project and proper folders for documents #77787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Infrastructure
untriaged
JoeRobich
commented
Mar 24, 2025
| var filePath = documentItem.ItemSpec; | ||
| var relativePath = PathUtilities.GetDirectoryName(PathUtilities.GetRelativePath(_projectDirectory, filePath)); | ||
| var folders = relativePath == null ? [] : relativePath.Split(PathUtilities.DirectorySeparatorChar, PathUtilities.AltDirectorySeparatorChar).ToImmutableArray(); | ||
| var folders = relativePath == null ? [] : relativePath.Split([PathUtilities.DirectorySeparatorChar, PathUtilities.AltDirectorySeparatorChar], StringSplitOptions.RemoveEmptyEntries).ToImmutableArray(); |
Member
Author
There was a problem hiding this comment.
For files in the same folder as the project file, PathUtilities.GetRelativePath(_projectDirectory, filePath) would always return filePath. Meaning PathUtilities.GetDirectoryName(...) would return "". Since we were not removing empty entries the resultant return would be [""].
Member
There was a problem hiding this comment.
Can we have a test for this one?
jasonmalinowski
approved these changes
Mar 24, 2025
dibarbet
approved these changes
Mar 25, 2025
JoeRobich
commented
Mar 25, 2025
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using System.Xml.Linq; | ||
| using Microsoft.CodeAnalysis.CSharp; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves dotnet/vscode-csharp#8091