Skip to content

Do not place 'static' on non-static operators #78305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CyrusNajmabadi merged 6 commits into from
Apr 25, 2025
Merged

Do not place 'static' on non-static operators #78305

CyrusNajmabadi merged 6 commits into from
Apr 25, 2025
+169 −34

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Apr 24, 2025 •
edited
Loading

Fixes #78281
Fixes #78282

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 24, 2025 21:29
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 24, 2025
JoeRobich
JoeRobich approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like many tests were baselined on the old behavior.

@CyrusNajmabadi CyrusNajmabadi merged commit f8e6e28 into dotnet:features/UserDefinedCompoundAssignment Apr 25, 2025
21 of 25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the ideWork branch April 25, 2025 19:19
This was referenced Apr 25, 2025
Closed
Closed
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 28, 2025 

[Theory(Skip = "Yes")] // PROTOTYPE: Something doesn't work

Can the test be unskipped now?

Refers to: src/Analyzers/CSharp/Tests/ImplementInterface/ImplementInterfaceTests.cs:11296 in 719e363. [](commit_id = 719e363, deletion_comment = False)

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 28, 2025 

[Theory(Skip = "Yes")] // PROTOTYPE: Something doesn't work

Can the test be unskipped now?

Refers to: src/Analyzers/CSharp/Tests/ImplementInterface/ImplementInterfaceTests.cs:11260 in 719e363. [](commit_id = 719e363, deletion_comment = False)

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 28, 2025 

            // PROTOTYPE: The 'static' modifier shouldn't be added

It looks like this comment can be deleted now

Refers to: src/EditorFeatures/Test/MetadataAsSource/MetadataAsSourceTests.CSharp.cs:737 in 719e363. [](commit_id = 719e363, deletion_comment = False)

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 28, 2025 

            // PROTOTYPE: The 'static' modifier shouldn't be added

It looks like this comment can be deleted now

Refers to: src/EditorFeatures/Test/MetadataAsSource/MetadataAsSourceTests.CSharp.cs:788 in 719e363. [](commit_id = 719e363, deletion_comment = False)

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 28, 2025 

            // PROTOTYPE: The 'static' modifier shouldn't be added

It looks like this comment can be deleted now

Refers to: src/EditorFeatures/Test/MetadataAsSource/MetadataAsSourceTests.CSharp.cs:845 in 719e363. [](commit_id = 719e363, deletion_comment = False)

@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 28, 2025 

            // PROTOTYPE: The 'static' modifier shouldn't be added

It looks like this comment can be deleted now

Refers to: src/EditorFeatures/Test/MetadataAsSource/MetadataAsSourceTests.CSharp.cs:909 in 719e363. [](commit_id = 719e363, deletion_comment = False)

@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Apr 28, 2025

Taking care of feedback in : #78349

This was referenced May 6, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CyrusNajmabadi @AlekseyTs @JoeRobich