Skip to content

Fix analyzer RCS0053 #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josefpihrt merged 8 commits into from
Sep 13, 2024
Merged

Fix analyzer RCS0053 #1512

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
76d240a
update
josefpihrt Sep 12, 2024
acede17
changelog
josefpihrt Sep 12, 2024
5dc8c22
fix
josefpihrt Sep 12, 2024
fddaeba
update
josefpihrt Sep 12, 2024
77e0304
update
josefpihrt Sep 12, 2024
def2c5d
update
josefpihrt Sep 12, 2024
97ef53e
update
josefpihrt Sep 13, 2024
2655155
update
josefpihrt Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@josefpihrt
josefpihrt committed Sep 12, 2024
commit fddaebaad8552ebfe64226e8a6ac0c59256564e1
12 changes: 6 additions & 6 deletions src/Formatting.Analyzers/CSharp/FixFormattingOfListAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ internal static BracesBlock GetBracesBlock(SyntaxNode node, TextLineCollection l
return default;

SyntaxToken openToken = node.FindToken(startIndex);
SyntaxNode block = null;
SyntaxNode enclosedNode = null;
var isOpenBraceAtEndOfLine = false;

if (IsOpenToken(openToken))
Expand All @@ -380,12 +380,12 @@ internal static BracesBlock GetBracesBlock(SyntaxNode node, TextLineCollection l
if (trailing.Any()
&& trailing.Span.Contains(startIndex))
{
block = openToken.Parent;
enclosedNode = openToken.Parent;
isOpenBraceAtEndOfLine = true;
}
}

if (block is null)
if (enclosedNode is null)
{
startIndex = line.EndIncludingLineBreak;
openToken = node.FindToken(startIndex);
Expand All @@ -397,18 +397,18 @@ internal static BracesBlock GetBracesBlock(SyntaxNode node, TextLineCollection l
if ((leading.Any() && leading.Span.Contains(startIndex))
|| (!leading.Any() && openToken.SpanStart == startIndex))
{
block = openToken.Parent;
enclosedNode = openToken.Parent;
}
}
}

if (block is not null)
if (enclosedNode is not null)
{
int endIndex = lines.GetLineFromPosition(node.Span.End).Start;
SyntaxToken closeToken = node.FindToken(endIndex);

if (IsCloseToken(closeToken)
&& object.ReferenceEquals(block, closeToken.Parent))
&& object.ReferenceEquals(enclosedNode, closeToken.Parent))
{
SyntaxTriviaList leading = closeToken.LeadingTrivia;

Expand Down