Skip to content

Fix RCS1202 - check if expr flow state is not null #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josefpihrt merged 2 commits into from
Sep 27, 2024
Merged

Fix RCS1202 - check if expr flow state is not null #1542

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab07f3a
update
josefpihrt Sep 27, 2024
297b3b0
update
josefpihrt Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
update
  • Loading branch information
@josefpihrt
josefpihrt committed Sep 27, 2024
commit ab07f3a9cb7e2dfb51ce3ec0f072d926ae4400b2
3 changes: 3 additions & 0 deletions src/Analyzers/CSharp/Analysis/AvoidNullReferenceExceptionAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,9 @@ private static void AnalyzeAsExpression(SyntaxNodeAnalysisContext context)
if (topExpression is null)
return;

if (semanticModel.GetTypeInfo(expression, cancellationToken).Nullability.FlowState == NullableFlowState.NotNull)
return;

if (semanticModel
.GetTypeSymbol(asExpression, cancellationToken)?
.IsReferenceType != true)
Expand Down
28 changes: 28 additions & 0 deletions src/Tests/Analyzers.Tests/RCS1202AvoidNullReferenceExceptionTests2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,34 @@ public void M()
(this as I).M();
}
}
");
}

[Fact, Trait(Traits.Analyzer, DiagnosticIdentifiers.AvoidNullReferenceException)]
public async Task TestNoDiagnostic_ExpressionIsDefinitelyNotNull()
{
await VerifyNoDiagnosticAsync(@"
#nullable enable

public interface I
{
void M() { }
}

public class P : I;

public class C
{
public required P P { get; set; }

public void M()
{
if (this.P is not null)
{
(this.P as I).M();
}
}
}
");
}
}