-
-
Notifications
You must be signed in to change notification settings - Fork 275
Fix RCS1085 with ref backing field #1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44c9974 to
54ec3c8
Compare
josefpihrt
previously approved these changes
Dec 9, 2025
josefpihrt
reviewed
Dec 9, 2025
Collaborator
josefpihrt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update changelog
54ec3c8 to
7190f49
Compare
Contributor
Author
|
Done, let me know if the changelog message is acceptable. |
josefpihrt
reviewed
Dec 13, 2025
josefpihrt
approved these changes
Dec 13, 2025
Collaborator
|
@ovska Thanks! 👍 |
This was referenced Dec 15, 2025
This was referenced Dec 15, 2025
Open
evgenygunko
pushed a commit
to evgenygunko/CopyWordsDA
that referenced
this pull request
Dec 15, 2025
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Roslynator.Analyzers](https://github.com/dotnet/roslynator) | nuget | minor | `4.14.1` -> `4.15.0` | --- ### Release Notes <details> <summary>dotnet/roslynator (Roslynator.Analyzers)</summary> ### [`v4.15.0`](https://github.com/dotnet/roslynator/blob/HEAD/ChangeLog.md#4150---2025-12-14) ##### Added - Add option `roslynator_null_conditional_operator.avoid_negative_boolean_comparison` ([PR](dotnet/roslynator#1688)) - Do not suggest to use null-conditional operator when result would be `... != true/false` - Applicable for [RCS1146](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1146) ##### Fixed - Fix analyzer [RCS1172](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1172) ([PR](dotnet/roslynator#1710)) - \[CLI] Fix `loc` command ([PR](dotnet/roslynator#1711)) - Exclude ref-field backed properties from [RCS1085](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1085) ([PR](dotnet/roslynator#1718) by [@​ovska](https://github.com/ovska)) - \[CLI] Fix `rename-symbol` scope option not being applied correctly ([PR](dotnet/roslynator#1720) by [@​andrtmschkw](https://github.com/andrtmschkw)) - \[CLI] Fix `rename-symbol` support for top-level statement ([PR](dotnet/roslynator#1721) by [@​andrtmschkw](https://github.com/andrtmschkw)) ##### Changed - Migrate to .NET 10 (including command-line tool) ([PR](dotnet/roslynator#1727)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or PR is renamed to start with "rebase!". 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
This was referenced Dec 15, 2025
Open
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
Dec 16, 2025
Updated [Roslynator.Analyzers](https://github.com/dotnet/roslynator) from 4.14.1 to 4.15.0. <details> <summary>Release notes</summary> _Sourced from [Roslynator.Analyzers's releases](https://github.com/dotnet/roslynator/releases)._ ## 4.15.0 ### Added - Add option `roslynator_null_conditional_operator.avoid_negative_boolean_comparison` ([PR](dotnet/roslynator#1688)) - Do not suggest to use null-conditional operator when result would be `... != true/false` - Applicable for [RCS1146](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1146) ### Fixed - Fix analyzer [RCS1172](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1172) ([PR](dotnet/roslynator#1710)) - [CLI] Fix `loc` command ([PR](dotnet/roslynator#1711)) - Exclude ref-field backed properties from [RCS1085](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1085) ([PR](dotnet/roslynator#1718) by @ovska) - [CLI] Fix `rename-symbol` scope option not being applied correctly ([PR](dotnet/roslynator#1720) by @andrtmschkw) - [CLI] Fix `rename-symbol` support for top-level statement ([PR](dotnet/roslynator#1721) by @andrtmschkw) ### Changed - Migrate to .NET 10 (including command-line tool) ([PR](dotnet/roslynator#1727)) Commits viewable in [compare view](dotnet/roslynator@v4.14.1...v4.15.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1717