Add Unicode 13.0 UCD assets #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note: the directory structure is a little different for the 13.0 assets. Instead of the directory structure emoji/{major}.{minor}, the emoji data files were moved under {major}.{minor}.{revision}/ucd/emoji. Not sure why Unicode did this, but whatever. :) I'll account for it at runtime ingestion time. |
ViktorHofer
approved these changes
Mar 12, 2020
Member
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
No additional action needed in regards to version. Everything flows automatically now :)
Member
Author
|
Tracking: The PR dotnet/runtime#33562 carries the assets payload for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the runtime-assets portion of dotnet/runtime#2378. Once the assets package is updated, we can ingest it within the runtime + libraries.
This PR contains select files copied from https://www.unicode.org/Public/13.0.0/.
I've also updated the third-party licenses file to point to their new license URL. The text is copied from https://www.unicode.org/license.html, everything after the heading "COPYRIGHT AND PERMISSION NOTICE". In practice the only things they updated were the URL and the copyright year.
Viktor, is there anything I need to do with regard to the package versions? I assume once the PR is merged the build system will automatically spit out new packages with an updated version number?