Skip to content

[release/8.0] Guard against -1 Returned from sysconf for the Cache Sizes Causing Large Gen0 Sizes and Budgets for Certain Linux Distributions. #100573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 14 commits into from
Closed

[release/8.0] Guard against -1 Returned from sysconf for the Cache Sizes Causing Large Gen0 Sizes and Budgets for Certain Linux Distributions. #100573

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
48682af
Logging.
mrsharm Apr 1, 2024
d4e7abc
Fixed comparison check
mrsharm Apr 1, 2024
15beb12
Fix logical operations
mrsharm Apr 1, 2024
0a7a08d
Completely guard against the cacheSize as UINTMAX_MAX
mrsharm Apr 1, 2024
440ae97
Fix for right macro
mrsharm Apr 1, 2024
6266af0
Ensure we are guarded against all cases where cacheSize == SIZE_MAX
mrsharm Apr 1, 2024
3257f16
Added an extra guard and removed redundant case
mrsharm Apr 2, 2024
750632a
Comment clean
mrsharm Apr 2, 2024
5f787a5
Added some additional asserts
mrsharm Apr 2, 2024
13e973b
Removed unnecessary checks for cacheSize == SIZE_MAX
mrsharm Apr 2, 2024
d162afe
Cleaned up logic
mrsharm Apr 2, 2024
65d7638
Fix type casting comparison
mrsharm Apr 2, 2024
b3dec7e
Removed redundant comment
mrsharm Apr 3, 2024
6efb287
Removed one more unneccesary guard
mrsharm Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Logging.
  • Loading branch information
@mrsharm
mrsharm authored and github-actions committed Apr 3, 2024
commit 48682aff5d724f20195855ae694a0c8295522fa4
10 changes: 7 additions & 3 deletions src/coreclr/gc/unix/gcenv.unix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,7 +792,7 @@ bool ReadMemoryValueFromFile(const char* filename, uint64_t* val)
return result;
}

#define UPDATE_CACHE_SIZE_AND_LEVEL(NEW_CACHE_SIZE, NEW_CACHE_LEVEL) if (NEW_CACHE_SIZE > cacheSize) { cacheSize = NEW_CACHE_SIZE; cacheLevel = NEW_CACHE_LEVEL; }
#define UPDATE_CACHE_SIZE_AND_LEVEL(NEW_CACHE_SIZE, NEW_CACHE_LEVEL) if ((NEW_CACHE_SIZE != UINTMAX_MAX) || NEW_CACHE_SIZE > cacheSize) { cacheSize = NEW_CACHE_SIZE; cacheLevel = NEW_CACHE_LEVEL; }

static size_t GetLogicalProcessorCacheSizeFromOS()
{
Expand All @@ -809,12 +809,16 @@ static size_t GetLogicalProcessorCacheSizeFromOS()
UPDATE_CACHE_SIZE_AND_LEVEL(size, 2)
#endif
#ifdef _SC_LEVEL3_CACHE_SIZE
size = ( size_t) sysconf(_SC_LEVEL3_CACHE_SIZE);
size_t level3_dcache_size;
size = level3_dcache_size = ( size_t) sysconf(_SC_LEVEL3_CACHE_SIZE);
UPDATE_CACHE_SIZE_AND_LEVEL(size, 3)
printf("[GetLogicalProcessorCacheSizeFromOS]: size after Level3DCacheSize (%zu): %zu\n", level3_dcache_size, size);
#endif
#ifdef _SC_LEVEL4_CACHE_SIZE
size = ( size_t) sysconf(_SC_LEVEL4_CACHE_SIZE);
size_t level4_dcache_size;
size = level4_dcache_size = ( size_t) sysconf(_SC_LEVEL4_CACHE_SIZE);
UPDATE_CACHE_SIZE_AND_LEVEL(size, 4)
printf("[GetLogicalProcessorCacheSizeFromOS]: size after Level4DCacheSize (%zu): %zu\n", level4_dcache_size, size);
#endif

#if defined(TARGET_LINUX) && !defined(HOST_ARM) && !defined(HOST_X86)
Expand Down