Skip to content

[release/8.0-staging] Guard against -1 Returned from sysconf for the Cache Sizes Causing Large Gen0 Sizes and Budgets for Certain Linux Distributions. #100575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericstj merged 14 commits into from
Apr 15, 2024
Merged

[release/8.0-staging] Guard against -1 Returned from sysconf for the Cache Sizes Causing Large Gen0 Sizes and Budgets for Certain Linux Distributions. #100575

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9107bb0
Logging.
mrsharm Apr 1, 2024
9742e62
Fixed comparison check
mrsharm Apr 1, 2024
6240d81
Fix logical operations
mrsharm Apr 1, 2024
481cb09
Completely guard against the cacheSize as UINTMAX_MAX
mrsharm Apr 1, 2024
a62a27b
Fix for right macro
mrsharm Apr 1, 2024
af93748
Ensure we are guarded against all cases where cacheSize == SIZE_MAX
mrsharm Apr 1, 2024
a45d625
Added an extra guard and removed redundant case
mrsharm Apr 2, 2024
cfffc5a
Comment clean
mrsharm Apr 2, 2024
116d307
Added some additional asserts
mrsharm Apr 2, 2024
54bd2c5
Removed unnecessary checks for cacheSize == SIZE_MAX
mrsharm Apr 2, 2024
7dfd687
Cleaned up logic
mrsharm Apr 2, 2024
ebb6fbe
Fix type casting comparison
mrsharm Apr 2, 2024
db8fde8
Removed redundant comment
mrsharm Apr 3, 2024
3fd50fe
Removed one more unneccesary guard
mrsharm Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed comparison check
  • Loading branch information
@mrsharm
mrsharm authored and github-actions committed Apr 3, 2024
commit 9742e627cb085a8e2c9ed942e6f5c96930861a72
8 changes: 2 additions & 6 deletions src/coreclr/gc/unix/gcenv.unix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -809,16 +809,12 @@ static size_t GetLogicalProcessorCacheSizeFromOS()
UPDATE_CACHE_SIZE_AND_LEVEL(size, 2)
#endif
#ifdef _SC_LEVEL3_CACHE_SIZE
size_t level3_dcache_size;
size = level3_dcache_size = ( size_t) sysconf(_SC_LEVEL3_CACHE_SIZE);
size = ( size_t) sysconf(_SC_LEVEL3_CACHE_SIZE);
UPDATE_CACHE_SIZE_AND_LEVEL(size, 3)
printf("[GetLogicalProcessorCacheSizeFromOS]: size after Level3DCacheSize (%zu): %zu\n", level3_dcache_size, size);
#endif
#ifdef _SC_LEVEL4_CACHE_SIZE
size_t level4_dcache_size;
size = level4_dcache_size = ( size_t) sysconf(_SC_LEVEL4_CACHE_SIZE);
size = ( size_t) sysconf(_SC_LEVEL4_CACHE_SIZE);
UPDATE_CACHE_SIZE_AND_LEVEL(size, 4)
printf("[GetLogicalProcessorCacheSizeFromOS]: size after Level4DCacheSize (%zu): %zu\n", level4_dcache_size, size);
#endif

#if defined(TARGET_LINUX) && !defined(HOST_ARM) && !defined(HOST_X86)
Expand Down