Skip to content

[infra] Enable trimming on Helix for Apple mobile #100669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kotlarmilos merged 19 commits into from
Apr 12, 2024
Merged

[infra] Enable trimming on Helix for Apple mobile #100669

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6d01e68
Add ILLink support to build machines
kotlarmilos Apr 5, 2024
0b3566c
Add ILLink support on Helix
kotlarmilos Apr 5, 2024
514ca0b
Fix trimming-related test failures
kotlarmilos Apr 5, 2024
a833a58
Fix ILLinkTasksAssembly path in AppleBuild.LocalBuild.props
kotlarmilos Apr 5, 2024
c6a9417
Override ILLinkTasksAssembly property
kotlarmilos Apr 5, 2024
67741a8
Set ILLinkTasksAssembly for NativeAOT tests
kotlarmilos Apr 5, 2024
f8b3092
Remove ILLink properties as they may not be necessary
kotlarmilos Apr 9, 2024
1ab228d
Remove redundant properties and add comments
kotlarmilos Apr 9, 2024
2fdf8ee
Revert ILLink switch properties
kotlarmilos Apr 9, 2024
1ad48a5
Split browser-specific configuration
ivanpovazan Apr 10, 2024
9152b15
Add description about _AdjustTrimmedAssembliesToBundle
ivanpovazan Apr 10, 2024
a078d5e
Use ActiveIssue with IsBuiltWithAggressiveTrimming for disabled tests
kotlarmilos Apr 11, 2024
76ce3d3
Trim tests only on PR builds
kotlarmilos Apr 11, 2024
8c7118a
Enable aggressive trimming by default
kotlarmilos Apr 11, 2024
f184b2d
Fix ident
kotlarmilos Apr 11, 2024
428d945
Fix buildArgs command
kotlarmilos Apr 11, 2024
f972c45
Fix ident
kotlarmilos Apr 11, 2024
74cf6c5
Fix ident
kotlarmilos Apr 11, 2024
37f41dd
Remove EnableSoftTrimming property
kotlarmilos Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ILLinkTasksAssembly path in AppleBuild.LocalBuild.props
  • Loading branch information
@kotlarmilos
kotlarmilos committed Apr 5, 2024
commit a833a581a7b54ba31d705cfa742eb85ba89256a1
4 changes: 2 additions & 2 deletions src/mono/msbuild/apple/build/AppleBuild.LocalBuild.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

<ILLinkPropsPath>$([MSBuild]::NormalizePath('$(ArtifactsBinDir)', 'ILLink.Tasks', '$(Configuration)', '$(_NetCoreAppToolCurrent)', 'build', 'Microsoft.NET.ILLink.Tasks.props'))</ILLinkPropsPath>
<ILLinkTargetsPath>$([MSBuild]::NormalizePath('$(ArtifactsBinDir)', 'ILLink.Tasks', '$(Configuration)', '$(_NetCoreAppToolCurrent)', 'build', 'Microsoft.NET.ILLink.targets'))</ILLinkTargetsPath>
<_ILLinkTasksAssembly>$([MSBuild]::NormalizePath('$(ArtifactsBinDir)', 'ILLink.Tasks', '$(Configuration)', '$(_NetCoreAppToolCurrent)', 'ILLink.Tasks.dll'))</_ILLinkTasksAssembly>
<ILLinkTasksAssembly>$([MSBuild]::NormalizePath('$(ArtifactsBinDir)', 'ILLink.Tasks', '$(Configuration)', '$(_NetCoreAppToolCurrent)', 'ILLink.Tasks.dll'))</ILLinkTasksAssembly>
</PropertyGroup>

<PropertyGroup Condition="'$(RuntimeSrcDir)' == '' and '$(AppleBuildSupportDir)' != ''">
Expand All @@ -70,7 +70,7 @@
<IlcFrameworkNativePath>$(MicrosoftNetCoreAppRuntimePackNativeDir)</IlcFrameworkNativePath>
<ILLinkPropsPath>$([MSBuild]::NormalizePath('$(BuildBaseDir)', '$(_NetCoreAppToolCurrent)', 'build', ''Microsoft.NET.ILLink.Tasks.props''))</ILLinkPropsPath>
<ILLinkTargetsPath>$([MSBuild]::NormalizePath('$(BuildBaseDir)', '$(_NetCoreAppToolCurrent)', 'build', 'Microsoft.NET.ILLink.targets'))</ILLinkTargetsPath>
<_ILLinkTasksAssembly>$([MSBuild]::NormalizePath('$(BuildBaseDir)', '$(_NetCoreAppToolCurrent)', 'ILLink.Tasks.dll'))</_ILLinkTasksAssembly>
<ILLinkTasksAssembly>$([MSBuild]::NormalizePath('$(BuildBaseDir)', '$(_NetCoreAppToolCurrent)', 'ILLink.Tasks.dll'))</ILLinkTasksAssembly>
<_MonoAotCrossCompilerPath>$([MSBuild]::NormalizePath($(MonoAotCrossDir), 'mono-aot-cross'))</_MonoAotCrossCompilerPath>
<_MonoAotCrossCompilerPath Condition="$([MSBuild]::IsOSPlatform('WINDOWS'))">$(_MonoAotCrossCompilerPath).exe</_MonoAotCrossCompilerPath>
</PropertyGroup>
Expand Down