Skip to content

JIT: Reorder stores to make them amenable to stp optimization #102133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 8 commits into from
May 15, 2024
Merged

JIT: Reorder stores to make them amenable to stp optimization #102133

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fe39722
JIT: Reorder stores to make them amenable to stp optimization
jakobbotsch May 12, 2024
6696818
Unmark tree; fix JITDUMP
jakobbotsch May 12, 2024
ef40b64
Remove outdated comment
jakobbotsch May 12, 2024
da4fbb1
Rephrase interference check
jakobbotsch May 12, 2024
fb718e5
Run jit-format
jakobbotsch May 12, 2024
233554a
Handle more constants
jakobbotsch May 13, 2024
eab1cbf
Merge branch 'main' of github.com:dotnet/runtime into make-store-indi…
jakobbotsch May 13, 2024
5a78b5e
Handle GT_CNS_DBL reuse as well
jakobbotsch May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unmark tree; fix JITDUMP
  • Loading branch information
@jakobbotsch
jakobbotsch committed May 12, 2024
commit 669681862a76a3f321f52b74de10ec41e98dd3a3
5 changes: 4 additions & 1 deletion src/coreclr/jit/lower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9212,6 +9212,7 @@ bool Lowering::TryMakeIndirsAdjacent(GenTreeIndir* prevIndir, GenTreeIndir* indi
if ((prevIndir->gtLIRFlags & LIR::Flags::Mark) != 0)
{
JITDUMP("Previous indir is part of the data flow of current indir\n");
UnmarkTree(indir);
return false;
}

Expand Down Expand Up @@ -9249,6 +9250,7 @@ bool Lowering::TryMakeIndirsAdjacent(GenTreeIndir* prevIndir, GenTreeIndir* indi
if (!indir->OperIsLoad())
{
JITDUMP("Have conservative interference with last store. Giving up.\n");
UnmarkTree(indir);
return false;
}

Expand Down Expand Up @@ -9348,7 +9350,7 @@ bool Lowering::TryMakeIndirsAdjacent(GenTreeIndir* prevIndir, GenTreeIndir* indi
}
}

JITDUMP("Interference checks passed: can to move unrelated nodes past second indir.\n");
JITDUMP("Interference checks passed: can move unrelated nodes past second indir.\n");

if (sawData)
{
Expand Down Expand Up @@ -9379,6 +9381,7 @@ bool Lowering::TryMakeIndirsAdjacent(GenTreeIndir* prevIndir, GenTreeIndir* indi
if (m_scratchSideEffects.InterferesWith(comp, prevIndir, true))
{
JITDUMP("Cannot move prev indir up after data computation\n");
UnmarkTree(indir);
return false;
}
}
Expand Down