Apply suggestions from code review

dotnet · rzikm · Jun 12, 2024 · May 23, 2024 · May 23, 2024 · May 23, 2024
commit ca364a7ee603fed4d49837a70e1a0d3e7cf5b6fb
diff --git a/src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs b/src/libraries/Common/src/Interop/Unix/System.Security.Cryptography.Native/Interop.OpenSsl.cs
@@ -331,7 +331,7 @@ internal static SafeSslHandle AllocateSslHandle(SslAuthenticationOptions sslAuth
                 }
                 else
                 {
-                    var key = new SslContextCacheKey(protocols, sslAuthenticationOptions.CertificateContext?.TargetCertificate.GetCertHash());
+                    var key = new SslContextCacheKey(protocols, sslAuthenticationOptions.CertificateContext?.TargetCertificate.GetCertHash(HashAlgorithmName.SHA256));
                     s_clientSslContexts.TryGetValue(key, out sslCtxHandle);
                 }
             }

diff --git a/src/native/libs/System.Security.Cryptography.Native/openssl.c b/src/native/libs/System.Security.Cryptography.Native/openssl.c
@@ -1278,7 +1278,6 @@ static void ExDataFreeNoOp(
     // do nothing.
 }
 
-
 static int ExDataDupNoOp(
     CRYPTO_EX_DATA* to,
 #if OPENSSL_VERSION_NUMBER >= OPENSSL_VERSION_1_1_0_RTM

diff --git a/src/native/libs/System.Security.Cryptography.Native/pal_ssl.h b/src/native/libs/System.Security.Cryptography.Native/pal_ssl.h
@@ -463,7 +463,7 @@ Shims the SSL_session_reused macro.
 PALEXPORT int32_t CryptoNative_SslSessionReused(SSL* ssl);
 
 /*
-Sets app data pointer to given session instance.
+Sets the app data pointer for the given session instance.
 */
 PALEXPORT void CryptoNative_SslSessionSetData(SSL_SESSION* session, void* val);
-Original file line number
+Diff line change
@@ Expand Up @@
                     }
                     else
                     {
-                        var key = new SslContextCacheKey(protocols, sslAuthenticationOptions.CertificateContext?.TargetCertificate.GetCertHash());
+                        var key = new SslContextCacheKey(protocols, sslAuthenticationOptions.CertificateContext?.TargetCertificate.GetCertHash(HashAlgorithmName.SHA256));
                         s_clientSslContexts.TryGetValue(key, out sslCtxHandle);
                     }
                 }
@@ Expand Down @@