Skip to content

Creating new TypeName without reparsing + usage in NRBF #103713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamsitnik merged 21 commits into from
Aug 14, 2024
Merged

Creating new TypeName without reparsing + usage in NRBF #103713

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
86595de
new TypeName methods
adamsitnik Jun 18, 2024
d906606
do not join the type and library name strings when UndoTruncatedTypeN…
adamsitnik Jun 19, 2024
448f01e
cache known primitive type names (and SZArrays of these)
adamsitnik Jun 19, 2024
b37b8da
add more tests and finish WithAssemblyName implementation
adamsitnik Jun 19, 2024
6b933d9
finish the implementation
adamsitnik Jun 28, 2024
f707dfd
Merge remote-tracking branch 'upstream/main' into extendTypeName
adamsitnik Jun 28, 2024
1736b24
add missing IntPtr and UIntPtr support (discovered once I've re-enabl…
adamsitnik Jun 28, 2024
a54e55f
use TypeNameMatches in more places
adamsitnik Jun 28, 2024
7d2d0d6
Merge remote-tracking branch 'upstream/main' into extendTypeName
adamsitnik Aug 2, 2024
9a0cd58
address API review feedback
adamsitnik Aug 2, 2024
aabe51b
remove CreateSimpleTypeName, introduce MakeSimpleTypeNameThrowsForNon…
adamsitnik Aug 2, 2024
e207e0f
handle nested names properly
adamsitnik Aug 6, 2024
19f1e82
update the code after reading it again on GH
adamsitnik Aug 6, 2024
6d03c00
Merge remote-tracking branch 'upstream/main' into extendTypeName
adamsitnik Aug 12, 2024
3abda02
address code review feedback
adamsitnik Aug 12, 2024
50a58fb
address code review feedback
adamsitnik Aug 12, 2024
ebfc35e
address code review feedback
adamsitnik Aug 13, 2024
f50ae19
rename MakeSimpleTypeName to WithAssemblyName
adamsitnik Aug 13, 2024
69cd1fa
Apply suggestions from code review
adamsitnik Aug 14, 2024
aa0870f
don't use sbyte to store array rank, the limit of 32 can be changed i…
adamsitnik Aug 14, 2024
30be71e
fix the build
adamsitnik Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into extendTypeName 
# Conflicts:
#	src/libraries/System.Formats.Nrbf/src/System/Formats/Nrbf/SerializationRecord.cs
  • Loading branch information
@adamsitnik
adamsitnik committed Aug 2, 2024
commit 7d2d0d6cba3881d5c403b853c0a552d7993ece0d

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.