Fix ILLink behavior for modreq types #108494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
Contributor
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
This was referenced Oct 2, 2024
Open
jtschuster
approved these changes
Oct 3, 2024
This was referenced Oct 4, 2024
Member
Author
|
/ba-g "dead-lettered work item" |
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Oct 8, 2024
Cecil represents modreq/modopt in signatures as part of the TypeReference (using subclasses RequiredModifierType/OptionalModifierType). We need to unwrap these to get the correct behavior in IsNamedType. This fixes the `IsTypeInterestingForDataflow` check for modreq/modopt types (`Type modreq(IsVolatile)` should be considered interesting for dataflow, and `Type[] modreq(IsVolatile)` should not). Includes a similar fix for function pointers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cecil represents modreq/modopt in signatures as part of the TypeReference (using subclasses RequiredModifierType/OptionalModifierType). We need to unwrap these to get the correct behavior in IsNamedType.
This fixes the
IsTypeInterestingForDataflowcheck for modreq/modopt types (Type modreq(IsVolatile)should be considered interesting for dataflow, andType[] modreq(IsVolatile)should not). Includes a similar fix for function pointers.Discovered while adding trim annotations in #108464.