ILLink: Avoid warning for RUC field rooted as part of a root assembly #108498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-Tools-ILLink
dotnet-policy-service
bot
added
the
linkable-framework
Contributor
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
This was referenced Oct 3, 2024
Open
jtschuster
approved these changes
Oct 3, 2024
src/tools/illink/test/Mono.Linker.Tests.Cases/RequiresCapability/RequiresInRootAllAssembly.cs
Outdated
Show resolved
Hide resolved
…ty/RequiresInRootAllAssembly.cs Co-authored-by: Jackson Schuster <[email protected]>
This was referenced Oct 3, 2024
Member
Author
|
/ba-g "dead-lettered work item and timeout" |
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Oct 8, 2024
…dotnet#108498) Similar to dotnet#81864, fields in a RUC class are producing trim analysis warnings in the OOB trim step (the mentioned issue was specific to library mode, but it's also a problem for the normal root assembly mode). This extends the fix from dotnet#84620 to avoid producing warnings for fields that are marked just because an assembly was rooted. Arguably rooting an assembly _should_ warn about rooted RUC members, but that's not the case today for RUC methods, so this makes the behavior consistent for fields. --------- Co-authored-by: Jackson Schuster <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #81864, fields in a RUC class are producing trim analysis warnings in the OOB trim step (the mentioned issue was specific to library mode, but it's also a problem for the normal root assembly mode).
This extends the fix from #84620 to avoid producing warnings for fields that are marked just because an assembly was rooted. There was some discussion around whether this is the right approach - since arguably rooting an assembly should warn about rooted RUC members. But that's not the case today for RUC methods, so this makes the behavior consistent for fields.
This came up in #108464.