Skip to content

Use current STJ in HostModel and remove unnecessary audit suppressions #109852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ViktorHofer merged 4 commits into from
Feb 4, 2025
Merged

Use current STJ in HostModel and remove unnecessary audit suppressions #109852

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29639d2
Use current STJ in HostModel and remove unnecessary audit suppressions
ViktorHofer Nov 15, 2024
2486ae4
Remove unnecessary nuget audit suppressions
ViktorHofer Nov 15, 2024
59cdc33
Merge branch 'main' into UseCurrentSTJInHostModelAndRemoveAuditSuppre…
ViktorHofer Feb 3, 2025
6b30ada
Remove SetConfiguration from ProjectReference
ViktorHofer Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove SetConfiguration from ProjectReference
  • Loading branch information
@ViktorHofer
ViktorHofer authored Feb 3, 2025
commit 6b30adafadd1a3d21c97ca46890ab749d2c4b76a
2 changes: 1 addition & 1 deletion src/installer/managed/Microsoft.NET.HostModel/Microsoft.NET.HostModel.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<PackageReference Include="System.Reflection.Metadata" Version="$(SystemReflectionMetadataToolsetVersion)" />
Copy link
Member

@ericstj ericstj Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one possible to replace too? I know we haven't had a CVE in this, but it would be nice if we could make all of HostModel's dependencies live.

Copy link
Member Author

@ViktorHofer ViktorHofer Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #112134

<PackageReference Include="System.Memory" Version="$(SystemMemoryVersion)" />
Copy link
Member

@am11 am11 Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Memory was required by STJ, it can also be removed now that STJ is coming from ProjectReference (which brings its own live System.Memory, transitively).


<ProjectReference Include="$(LibrariesProjectRoot)System.Text.Json\src\System.Text.Json.csproj" SetConfiguration="Configuration=$(LibrariesConfiguration)" />
<ProjectReference Include="$(LibrariesProjectRoot)System.Text.Json\src\System.Text.Json.csproj" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading