Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review
Co-authored-by: Elinor Fung <[email protected]>
  • Loading branch information
filipnavara and elinor-fung authored Feb 1, 2025
commit 56f87fa67a0773a5b2812d8d0bb40089aad917fe
4 changes: 2 additions & 2 deletions src/native/corehost/json_parser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ bool json_parser_t::parse_file(const pal::string_t& path)
if (m_data == nullptr)
{
#ifdef _WIN32
// Since we can't use in-situ parsing on Windows, as JSON data is encoded in
// We can't use in-situ parsing on Windows, as JSON data is encoded in
// UTF-8 and the host expects wide strings.
// We do not need COW and read-only mapping will be enough.
// We do not need copy-on-write, so read-only mapping will be enough.
m_data = (char*)pal::mmap_read(path, &m_size);
#else // _WIN32
m_data = (char*)pal::mmap_copy_on_write(path, &m_size);
Expand Down
2 changes: 1 addition & 1 deletion src/native/corehost/json_parser.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class json_parser_t {
// to UTF-16 by m_document during load.
document_t m_document;

// If a json file is parsed from a single-file bundle, the following two fields represents
// If a json file is parsed from a single-file bundle, the following fields represents
// the location of this json file within the bundle.
const bundle::location_t* m_bundle_location;
};
Expand Down
Loading