Skip to content

JIT: Unify handling of InstParam argument during inlining #112119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 3 commits into from
Feb 4, 2025
Merged

JIT: Unify handling of InstParam argument during inlining #112119

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31f64c8
JIT: Unify handling of InstParam argument during inlining
jakobbotsch Jan 30, 2025
c6747f7
Nit
jakobbotsch Feb 4, 2025
c6cad00
Nit
jakobbotsch Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Nit
  • Loading branch information
@jakobbotsch
jakobbotsch committed Feb 4, 2025
commit c6cad00f36e080a6281ce5b968dbb9a014c8770b
8 changes: 2 additions & 6 deletions src/coreclr/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12980,6 +12980,8 @@ void Compiler::impInlineRecordArgInfo(InlineInfo* pInlineInfo,
argInfo->argIsLclVar = true;
}

argInfo->argIsThis = arg->GetWellKnownArg() == WellKnownArg::ThisPointer;

if (impIsInvariant(curArgVal))
{
argInfo->argIsInvariant = true;
Expand All @@ -12996,8 +12998,6 @@ void Compiler::impInlineRecordArgInfo(InlineInfo* pInlineInfo,
argInfo->argHasSideEff = false;
}

argInfo->argIsThis = arg->GetWellKnownArg() == WellKnownArg::ThisPointer;

bool isExact = false;
bool isNonNull = false;
argInfo->argIsExact = (gtGetClassHandle(curArgVal, &isExact, &isNonNull) != NO_CLASS_HANDLE) && isExact;
Expand Down Expand Up @@ -13114,10 +13114,6 @@ void Compiler::impInlineInitVars(InlineInfo* pInlineInfo)
InlArgInfo* argInfo;
switch (arg.GetWellKnownArg())
{
case WellKnownArg::ThisPointer:
argInfo = &inlArgInfo[ilArgCnt++];
argInfo->argIsThis = true;
break;
case WellKnownArg::RetBuffer:
// This does not appear in the table of inline arg info; do not include them
continue;
Expand Down
Loading